Sign upLogin

docker/swarmkit

View on GitHub
Star
swarmd/dockerexec/container.go

Summary

Maintainability
B
4 hrs
Test Coverage

containerConfig has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

type containerConfig struct {
    task                *api.Task
    networksAttachments map[string]*api.NetworkAttachment
}
Severity: Minor
Found in swarmd/dockerexec/container.go - About 2 hrs to fix

    Function convertMount has 58 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func convertMount(m api.Mount) enginemount.Mount {
    mount := enginemount.Mount{
        Source:   m.Source,
        Target:   m.Target,
        ReadOnly: m.ReadOnly,
    Severity: Minor
    Found in swarmd/dockerexec/container.go - About 1 hr to fix

      Function getMountMask has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func getMountMask(m *api.Mount) string {
    var maskOpts []string
    if m.ReadOnly {
        maskOpts = append(maskOpts, "ro")
    }
      Severity: Minor
      Found in swarmd/dockerexec/container.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status