Sign upLogin

dolittle/DotNET.SDK

View on GitHub
Star

Showing 230 of 230 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if (!source.AggregateRootId.TryTo<AggregateRootId>(out var aggregateRootId, out var aggregateRootIdError))
        {
            error = new InvalidCommittedEventInformation(nameof(source.AggregateRootId), aggregateRootIdError);
            return false;
        }
Severity: Major
Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs and 4 other locations - About 30 mins to fix
Source/Events.Processing/EventProcessingConverter.cs on lines 49..53
Source/Protobuf/ExecutionContextExtensions.cs on lines 56..60
Source/Protobuf/ExecutionContextExtensions.cs on lines 62..66
Source/Protobuf/ExecutionContextExtensions.cs on lines 74..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public Task Register(IEnumerable<EventType> eventTypes, CancellationToken cancellationToken)
        => Task.WhenAll(eventTypes.Select(CreateRequest).Select(_ => Register(_, cancellationToken)));
Severity: Minor
Found in Source/Events/Internal/EventTypesClient.cs and 1 other location - About 30 mins to fix
Source/Aggregates/Internal/AggregateRootsClient.cs on lines 48..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            catch (Exception ex)
            {
                var oldAggregate = _createAggregate();
                ApplyEvents(oldAggregate, previousAppliedEvents);
                _persistOldAggregate(oldAggregate);
Severity: Minor
Found in Source/Testing/Aggregates/AggregateRootOperationsMock.cs and 1 other location - About 30 mins to fix
Source/Testing/Aggregates/AggregateRootOperationsMock.cs on lines 81..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            catch (Exception ex)
            {
                var oldAggregate = _createAggregate();
                ApplyEvents(oldAggregate, previousAppliedEvents);
                _persistOldAggregate(oldAggregate);
Severity: Minor
Found in Source/Testing/Aggregates/AggregateRootOperationsMock.cs and 1 other location - About 30 mins to fix
Source/Testing/Aggregates/AggregateRootOperationsMock.cs on lines 126..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [Benchmark]
    public Task Applying1Event100TimesWithNothingToReplay()
    {
        return Task.WhenAll(
            Apply100Stupid("aggregate1"),
Severity: Minor
Found in Benchmarks/SDK/AggregateRoots/with_1_tenant/applying_events_with_nothing_to_replay_for_four_aggregate_roots.cs and 1 other location - About 30 mins to fix
Benchmarks/SDK/AggregateRoots/with_1_tenant/applying_events_with_nothing_to_replay_for_four_aggregate_roots.cs on lines 36..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public Task Register(IEnumerable<AggregateRootType> aggregateRootTypes, CancellationToken cancellationToken)
        => Task.WhenAll(aggregateRootTypes.Select(CreateRequest).Select(_ => Register(_, cancellationToken)));
Severity: Minor
Found in Source/Aggregates/Internal/AggregateRootsClient.cs and 1 other location - About 30 mins to fix
Source/Events/Internal/EventTypesClient.cs on lines 48..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [Benchmark]
    public Task Applying100EventsWithNothingToReplay()
    {
        return Task.WhenAll(
            Apply100Events("aggregate1"),
Severity: Minor
Found in Benchmarks/SDK/AggregateRoots/with_1_tenant/applying_events_with_nothing_to_replay_for_four_aggregate_roots.cs and 1 other location - About 30 mins to fix
Benchmarks/SDK/AggregateRoots/with_1_tenant/applying_events_with_nothing_to_replay_for_four_aggregate_roots.cs on lines 58..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return false;
    Severity: Major
    Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in Source/Protobuf/ExecutionContextExtensions.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                if (typeInfo.Type is null) return;
        Severity: Major
        Found in Source/Analyzers/EventsHaveAnnotationAnalyzer.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in Source/Events/Store/Converters/EventToSDKConverter.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    if (typeInfo.Type.HasEventTypeAttribute()) return; // All good
            Severity: Major
            Found in Source/Analyzers/EventsHaveAnnotationAnalyzer.cs - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      if (typeInfo.Type.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat).Equals("object")) return;
              Severity: Major
              Found in Source/Analyzers/EventsHaveAnnotationAnalyzer.cs - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return updatedDocument.Project.Solution;
                Severity: Major
                Found in Source/Analyzers/CodeFixes/AttributeMissingCodeFixProvider.cs - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return (argument.Value, syntaxNode.GetLocation());
                  Severity: Major
                  Found in Source/Analyzers/EventHandlerAnalyzer.cs - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return true;
                    Severity: Major
                    Found in Source/Protobuf/ArtifactExtensions.cs - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return false;
                      Severity: Major
                      Found in Source/Events/Store/Converters/EventToSDKConverter.cs - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in Source/Protobuf/ArtifactExtensions.cs - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  if (targetDocument is null) return document.Project.Solution;
                          Severity: Major
                          Found in Source/Analyzers/CodeFixes/AttributeMissingCodeFixProvider.cs - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language