Sign upLogin

dotcloud/docker

View on GitHub
Star
api/server/router/network/network_routes.go

Summary

Maintainability
C
1 day
Test Coverage

Method networkRouter.getNetwork has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

func (n *networkRouter) getNetwork(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
Severity: Minor
Found in api/server/router/network/network_routes.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method networkRouter.getNetwork has 76 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (n *networkRouter) getNetwork(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
Severity: Major
Found in api/server/router/network/network_routes.go - About 2 hrs to fix

    Method networkRouter.findUniqueNetwork has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func (n *networkRouter) findUniqueNetwork(term string) (network.Inspect, error) {
    listByFullName := map[string]network.Inspect{}
    listByPartialID := map[string]network.Inspect{}

    filter := filters.NewArgs(filters.Arg("idOrName", term))
    Severity: Minor
    Found in api/server/router/network/network_routes.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method networkRouter.getNetwork has 10 return statements (exceeds 4 allowed).
    Open

    func (n *networkRouter) getNetwork(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
    Severity: Major
    Found in api/server/router/network/network_routes.go - About 1 hr to fix

      Method networkRouter.findUniqueNetwork has 7 return statements (exceeds 4 allowed).
      Open

      func (n *networkRouter) findUniqueNetwork(term string) (network.Inspect, error) {
    listByFullName := map[string]network.Inspect{}
    listByPartialID := map[string]network.Inspect{}

    filter := filters.NewArgs(filters.Arg("idOrName", term))
      Severity: Major
      Found in api/server/router/network/network_routes.go - About 45 mins to fix

        Method networkRouter.postNetworkCreate has 6 return statements (exceeds 4 allowed).
        Open

        func (n *networkRouter) postNetworkCreate(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
        Severity: Major
        Found in api/server/router/network/network_routes.go - About 40 mins to fix

          Method networkRouter.deleteNetwork has 5 return statements (exceeds 4 allowed).
          Open

          func (n *networkRouter) deleteNetwork(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
          Severity: Major
          Found in api/server/router/network/network_routes.go - About 35 mins to fix

            Method networkRouter.getNetworksList has 5 return statements (exceeds 4 allowed).
            Open

            func (n *networkRouter) getNetworksList(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
            Severity: Major
            Found in api/server/router/network/network_routes.go - About 35 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              func (n *networkRouter) postNetworksPrune(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
              Severity: Major
              Found in api/server/router/network/network_routes.go and 2 other locations - About 1 hr to fix
              api/server/router/image/image_routes.go on lines 509..524
              api/server/router/container/container_routes.go on lines 1055..1070

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 180.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status