Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/kill.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Daemon.killWithSignal has 75 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) killWithSignal(container *containerpkg.Container, stopSignal syscall.Signal) error {
    log.G(context.TODO()).WithFields(log.Fields{
        "signal":    int(stopSignal),
        "container": container.ID,
    }).Debugf("sending signal %[1]d (%[1]s) to container", stopSignal)
Severity: Minor
Found in daemon/kill.go - About 2 hrs to fix

    Method Daemon.killWithSignal has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) killWithSignal(container *containerpkg.Container, stopSignal syscall.Signal) error {
    log.G(context.TODO()).WithFields(log.Fields{
        "signal":    int(stopSignal),
        "container": container.ID,
    }).Debugf("sending signal %[1]d (%[1]s) to container", stopSignal)
    Severity: Minor
    Found in daemon/kill.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Daemon.Kill has 7 return statements (exceeds 4 allowed).
    Open

    func (daemon *Daemon) Kill(container *containerpkg.Container) error {
    if !container.IsRunning() {
        return errNotRunning(container.ID)
    }
    Severity: Major
    Found in daemon/kill.go - About 45 mins to fix

      Method Daemon.killWithSignal has 5 return statements (exceeds 4 allowed).
      Open

      func (daemon *Daemon) killWithSignal(container *containerpkg.Container, stopSignal syscall.Signal) error {
    log.G(context.TODO()).WithFields(log.Fields{
        "signal":    int(stopSignal),
        "container": container.ID,
    }).Debugf("sending signal %[1]d (%[1]s) to container", stopSignal)
      Severity: Major
      Found in daemon/kill.go - About 35 mins to fix

        Method Daemon.ContainerKill has 5 return statements (exceeds 4 allowed).
        Open

        func (daemon *Daemon) ContainerKill(name, stopSignal string) error {
    var (
        err error
        sig = syscall.SIGKILL
    )
        Severity: Major
        Found in daemon/kill.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status