Sign upLogin

dotcloud/docker

View on GitHub
Star
distribution/pull.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function pullEndpoints has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

func pullEndpoints(ctx context.Context, registryService RegistryResolver, ref reference.Named,
    f func(context.Context, registry.RepositoryInfo, registry.APIEndpoint) error,
) (*registry.RepositoryInfo, error) {
    // Resolve the Repository name from fqn to RepositoryInfo
    repoInfo, err := registryService.ResolveRepository(ref)
Severity: Minor
Found in distribution/pull.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function pullEndpoints has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func pullEndpoints(ctx context.Context, registryService RegistryResolver, ref reference.Named,
    f func(context.Context, registry.RepositoryInfo, registry.APIEndpoint) error,
) (*registry.RepositoryInfo, error) {
    // Resolve the Repository name from fqn to RepositoryInfo
    repoInfo, err := registryService.ResolveRepository(ref)
Severity: Minor
Found in distribution/pull.go - About 1 hr to fix

    Function pullEndpoints has 6 return statements (exceeds 4 allowed).
    Open

    func pullEndpoints(ctx context.Context, registryService RegistryResolver, ref reference.Named,
    f func(context.Context, registry.RepositoryInfo, registry.APIEndpoint) error,
) (*registry.RepositoryInfo, error) {
    // Resolve the Repository name from fqn to RepositoryInfo
    repoInfo, err := registryService.ResolveRepository(ref)
    Severity: Major
    Found in distribution/pull.go - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status