Sign upLogin

dotcloud/docker

View on GitHub
Star
integration/internal/swarm/service.go

Summary

Maintainability
A
1 hr
Test Coverage

Function ExecTask has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func ExecTask(ctx context.Context, t *testing.T, d *daemon.Daemon, task swarmtypes.Task, options container.ExecOptions) types.HijackedResponse {
Severity: Minor
Found in integration/internal/swarm/service.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func ServicePoll(config *poll.Settings) {
    // Override the default pollSettings for `service` resource here ...
    config.Timeout = 15 * time.Second
    config.Delay = 100 * time.Millisecond
    if runtime.GOARCH == "arm64" || runtime.GOARCH == "arm" {
    Severity: Minor
    Found in integration/internal/swarm/service.go and 1 other location - About 35 mins to fix
    integration/internal/swarm/service.go on lines 32..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func NetworkPoll(config *poll.Settings) {
    // Override the default pollSettings for `network` resource here ...
    config.Timeout = 30 * time.Second
    config.Delay = 100 * time.Millisecond
    Severity: Minor
    Found in integration/internal/swarm/service.go and 1 other location - About 35 mins to fix
    integration/internal/swarm/service.go on lines 22..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status