Sign upLogin

dotcloud/docker

View on GitHub
Star

Showing 1,468 of 1,914 total issues

Method EndpointRecord.MarshalToSizedBuffer has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (m *EndpointRecord) MarshalToSizedBuffer(dAtA []byte) (int, error) {
    i := len(dAtA)
    _ = i
    var l int
    _ = l
Severity: Minor
Found in libnetwork/agent.pb.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Endpoint.deleteServiceInfoFromCluster has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (ep *Endpoint) deleteServiceInfoFromCluster(sb *Sandbox, fullRemove bool, method string) error {
    if len(ep.dnsNames) == 0 {
        return nil
    }
Severity: Minor
Found in libnetwork/agent.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Sandbox.clearNetworkResources has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (sb *Sandbox) clearNetworkResources(origEp *Endpoint) error {
    ep := sb.GetEndpoint(origEp.id)
    if ep == nil {
        return fmt.Errorf("could not find the sandbox endpoint data for endpoint %s",
            origEp.id)
Severity: Minor
Found in libnetwork/sandbox.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method driver.NetworkAllocate has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (d *driver) NetworkAllocate(id string, option map[string]string, ipV4Data, ipV6Data []driverapi.IPAMData) (map[string]string, error) {
    if id == "" {
        return nil, fmt.Errorf("invalid network id for overlay network")
    }
Severity: Minor
Found in libnetwork/drivers/overlay/ovmanager/ovmanager.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function programSA has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (fSA *netlink.XfrmState, rSA *netlink.XfrmState, err error) {
    var (
        action      = "Removing"
        xfrmProgram = ns.NlHandle().XfrmStateDel
    )
Severity: Minor
Found in libnetwork/drivers/overlay/encryption.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method driver.DeleteNetwork has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (d *driver) DeleteNetwork(nid string) error {
    n := d.network(nid)
    if n == nil {
        return fmt.Errorf("network id %s not found", nid)
    }
Severity: Minor
Found in libnetwork/drivers/macvlan/macvlan_network.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method driver.CreateEndpoint has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (d *driver) CreateEndpoint(ctx context.Context, nid, eid string, ifInfo driverapi.InterfaceInfo, epOptions map[string]interface{}) error {
    if err := validateID(nid, eid); err != nil {
        return err
    }
    n, err := d.getNetwork(nid)
Severity: Minor
Found in libnetwork/drivers/macvlan/macvlan_endpoint.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Sandbox.needDefaultGW has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (sb *Sandbox) needDefaultGW() bool {
    var needGW bool

    for _, ep := range sb.Endpoints() {
        if ep.endpointInGWNetwork() {
Severity: Minor
Found in libnetwork/default_gateway.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method UDPProxy.Run has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (proxy *UDPProxy) Run() {
    readBuf := make([]byte, UDPBufSize)
    var oob []byte
    if proxy.ipVer == ip4 {
        oob = ipv4.NewControlMessage(ipv4.FlagDst)
Severity: Minor
Found in cmd/docker-proxy/udp_proxy_linux.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseEndpointOptions has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func parseEndpointOptions(epOptions map[string]interface{}) (*endpointOption, error) {
    if epOptions == nil {
        return nil, nil
    }
Severity: Minor
Found in libnetwork/drivers/windows/windows.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getMountOptions has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func getMountOptions(opts *optsConfig, resolveIP func(string, string) (*net.IPAddr, error)) (mountDevice string, mountOpts string, _ error) {
    if opts.MountDevice == "" {
        return "", "", fmt.Errorf("missing device in volume options")
    }
Severity: Minor
Found in volume/local/local_unix.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method driver.parseNetworkOptions has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (d *driver) parseNetworkOptions(id string, genericOptions map[string]string) (*networkConfiguration, error) {
    config := &networkConfiguration{Type: d.name}

    for label, value := range genericOptions {
        switch label {
Severity: Minor
Found in libnetwork/drivers/windows/windows.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Builder.dispatchDockerfileWithCancellation has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (b *Builder) dispatchDockerfileWithCancellation(ctx context.Context, parseResult []instructions.Stage, metaArgs []instructions.ArgCommand, escapeToken rune, source builder.Source) (*dispatchState, error) {
    dispatchRequest := dispatchRequest{}
    buildArgs := NewBuildArgs(b.options.BuildArgs)
    totalCommands := len(metaArgs) + len(parseResult)
    currentCommandIndex := 1
Severity: Minor
Found in builder/dockerfile/builder.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ValidateIPAM has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func ValidateIPAM(ipam *IPAM, enableIPv6 bool) error {
    if ipam == nil {
        return nil
    }
Severity: Minor
Found in api/types/network/ipam.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method client.extractResourcesFromSpec has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (c *client) extractResourcesFromSpec(spec *specs.Spec, configuration *hcsshim.ContainerConfig) {
    if spec.Windows.Resources != nil {
        if spec.Windows.Resources.CPU != nil {
            if spec.Windows.Resources.CPU.Count != nil {
                // This check is being done here rather than in adaptContainerSettings
Severity: Minor
Found in libcontainerd/local/local_windows.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method containerConfig.applyPrivileges has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (c *containerConfig) applyPrivileges(hc *containertypes.HostConfig) {
    privileges := c.spec().Privileges
    if privileges == nil {
        return
    }
Severity: Minor
Found in daemon/cluster/executor/container/container.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method reader.readLogs has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (r *reader) readLogs(ctx context.Context) {
    defer close(r.logWatcher.Msg)

    // Make sure the ready channel is closed in the event of an early
    // return.
Severity: Minor
Found in daemon/logger/journald/read.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function New has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func New(info logger.Info) (logger.Logger, error) {
    containerStreamConfig, err := newStreamConfig(info)
    if err != nil {
        return nil, err
    }
Severity: Minor
Found in daemon/logger/awslogs/cloudwatchlogs.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getTailReader has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func getTailReader(ctx context.Context, r loggerutils.SizeReaderAt, req int) (loggerutils.SizeReaderAt, int, error) {
    size := r.Size()
    if req < 0 {
        return nil, 0, errdefs.InvalidParameter(errors.Errorf("invalid number of lines to tail: %d", req))
    }
Severity: Minor
Found in daemon/logger/local/read.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Daemon.execSetPlatformOpt has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func (daemon *Daemon) execSetPlatformOpt(ctx context.Context, daemonCfg *config.Config, ec *container.ExecConfig, p *specs.Process) error {
    if len(ec.User) > 0 {
        var err error
        if daemon.UsesSnapshotter() {
            p.User, err = getUserFromContainerd(ctx, daemon.containerdClient, ec)
Severity: Minor
Found in daemon/exec_linux.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language