dotcloud/docker

Method ImageService.SquashImage has 8 return statements (exceeds 4 allowed).

Open

func (i *ImageService) SquashImage(id, parent string) (string, error) {
    var (
        img *image.Image
        err error
    )

Method Daemon.containerCopy has 8 return statements (exceeds 4 allowed).

Open

func (daemon *Daemon) containerCopy(container *container.Container, resource string) (rc io.ReadCloser, err error) {
    if resource[0] == '/' || resource[0] == '\\' {
        resource = resource[1:]
    }
    container.Lock()

Function CopyInfoDestinationPath has 8 return statements (exceeds 4 allowed).

Open

func CopyInfoDestinationPath(path string) (info CopyInfo, err error) {
    maxSymlinkIter := 10 // filepath.EvalSymlinks uses 255, but 10 already seems like a lot.
    path = normalizePath(path)
    originalPath := path

Function listenFD has 8 return statements (exceeds 4 allowed).

Open

func listenFD(addr string, tlsConfig *tls.Config) ([]net.Listener, error) {
    var (
        err       error
        listeners []net.Listener
    )

Function parseUintList has 8 return statements (exceeds 4 allowed).

Open

func parseUintList(val string, maximum int) (map[int]bool, error) {
    if val == "" {
        return map[int]bool{}, nil
    }

Function collectFileInfo has 8 return statements (exceeds 4 allowed).

Open

func collectFileInfo(sourceDir string) (*FileInfo, error) {
    root := newRootFileInfo()

    err := filepath.WalkDir(sourceDir, func(path string, _ os.DirEntry, err error) error {
        if err != nil {

Method layerStore.ReleaseRWLayer has 8 return statements (exceeds 4 allowed).

Open

func (ls *layerStore) ReleaseRWLayer(l RWLayer) ([]Metadata, error) {
    name := l.Name()
    ls.locker.Lock(name)
    defer ls.locker.Unlock(name)

Function mkdirAs has 8 return statements (exceeds 4 allowed).

Open

func mkdirAs(path string, mode os.FileMode, owner Identity, mkAll, chownExisting bool) error {
    path, err := filepath.Abs(path)
    if err != nil {
        return err
    }

Method layerStore.loadLayer has 8 return statements (exceeds 4 allowed).

Open

func (ls *layerStore) loadLayer(layer ChainID) (*roLayer, error) {
    cl, ok := ls.layerMap[layer]
    if ok {
        return cl, nil
    }

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func (d *driver) CreateNetwork(id string, option map[string]interface{}, nInfo driverapi.NetworkInfo, ipV4Data, ipV6Data []driverapi.IPAMData) error {
    d.Lock()
    defer d.Unlock()

    if d.network != "" {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    for name, node := range nDB.failedNodes {
        if node.Addr.Equal(mn.Addr) && node.Port == mn.Port && mn.Name != name {
            log.G(context.TODO()).Infof("Node %s/%s, is the new incarnation of the failed node %s/%s", mn.Name, mn.Addr, name, node.Addr)
            nDB.changeNodeState(name, nodeLeftState)
            return true

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (e *namesByContainerIDIndexer) FromArgs(args ...interface{}) ([]byte, error) {
    if len(args) != 1 {
        return nil, fmt.Errorf("must provide only a single argument")
    }
    arg, ok := args[0].(string)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func (d *driver) CreateNetwork(id string, option map[string]interface{}, nInfo driverapi.NetworkInfo, ipV4Data, ipV6Data []driverapi.IPAMData) error {
    d.Lock()
    defer d.Unlock()

    if d.network != "" {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    for name, node := range nDB.nodes {
        if node.Addr.Equal(mn.Addr) && node.Port == mn.Port && mn.Name != name {
            log.G(context.TODO()).Infof("Node %s/%s, is the new incarnation of the active node %s/%s", mn.Name, mn.Addr, name, node.Addr)
            nDB.changeNodeState(name, nodeLeftState)
            return true

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    for name, node := range nDB.leftNodes {
        if node.Addr.Equal(mn.Addr) && node.Port == mn.Port && mn.Name != name {
            log.G(context.TODO()).Infof("Node %s/%s, is the new incarnation of the shutdown node %s/%s", mn.Name, mn.Addr, name, node.Addr)
            nDB.changeNodeState(name, nodeLeftState)
            return true

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (e *namesByNameIndexer) FromArgs(args ...interface{}) ([]byte, error) {
    if len(args) != 1 {
        return nil, fmt.Errorf("must provide only a single argument")
    }
    arg, ok := args[0].(string)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (sr *swarmRouter) removeConfig(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := sr.backend.RemoveConfig(vars["id"]); err != nil {
        return err
    }
    w.WriteHeader(http.StatusNoContent)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func ulimitsToGRPC(u []*container.Ulimit) []*swarmapi.ContainerSpec_Ulimit {
    ulimits := make([]*swarmapi.ContainerSpec_Ulimit, len(u))

    for i, ulimit := range u {
        ulimits[i] = &swarmapi.ContainerSpec_Ulimit{

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

package main

import (
    "net"
    "net/http"

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

package main

import (
    "net"
    "net/http"

• Read up
  Read up