dotcloud/docker

View on GitHub

Showing 1,904 of 1,904 total issues

Method Daemon.initNetworkController has 8 return statements (exceeds 4 allowed).
Open

func (daemon *Daemon) initNetworkController(daemonCfg *config.Config, activeSandboxes map[string]interface{}) error {
    netOptions, err := daemon.networkOptions(daemonCfg, nil, daemon.id, nil)
    if err != nil {
        return err
    }
Severity: Major
Found in daemon/daemon_windows.go - About 50 mins to fix

    Method ImageService.CommitImage has 8 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) CommitImage(ctx context.Context, cc backend.CommitConfig) (image.ID, error) {
        container := i.containers.Get(cc.ContainerID)
        cs := i.content
    
        var parentManifest ocispec.Manifest
    Severity: Major
    Found in daemon/containerd/image_commit.go - About 50 mins to fix

      Method ImageService.CreateImage has 8 return statements (exceeds 4 allowed).
      Open

      func (i *ImageService) CreateImage(ctx context.Context, config []byte, parent string, layerDigest digest.Digest) (builder.Image, error) {
          imgToCreate, err := dimage.NewFromJSON(config)
          if err != nil {
              return nil, err
          }
      Severity: Major
      Found in daemon/containerd/image_builder.go - About 50 mins to fix

        Method ImageService.TagImage has 8 return statements (exceeds 4 allowed).
        Open

        func (i *ImageService) TagImage(ctx context.Context, imageID image.ID, newTag reference.Named) error {
            targetImage, err := i.resolveImage(ctx, imageID.String())
            if err != nil {
                return errors.Wrapf(err, "failed to resolve image id %q to a descriptor", imageID.String())
            }
        Severity: Major
        Found in daemon/containerd/image_tag.go - About 50 mins to fix

          Method Cluster.Leave has 8 return statements (exceeds 4 allowed).
          Open

          func (c *Cluster) Leave(ctx context.Context, force bool) error {
              c.controlMutex.Lock()
              defer c.controlMutex.Unlock()
          
              c.mu.Lock()
          Severity: Major
          Found in daemon/cluster/swarm.go - About 50 mins to fix

            Method controller.Logs has 8 return statements (exceeds 4 allowed).
            Open

            func (r *controller) Logs(ctx context.Context, publisher exec.LogPublisher, options api.LogSubscriptionOptions) error {
                if err := r.checkClosed(); err != nil {
                    return err
                }
            
            
            Severity: Major
            Found in daemon/cluster/executor/container/controller.go - About 50 mins to fix

              Method Cluster.Join has 8 return statements (exceeds 4 allowed).
              Open

              func (c *Cluster) Join(req types.JoinRequest) error {
                  c.controlMutex.Lock()
                  defer c.controlMutex.Unlock()
                  c.mu.Lock()
                  if c.nr != nil {
              Severity: Major
              Found in daemon/cluster/swarm.go - About 50 mins to fix

                Method Cluster.GetTasks has 8 return statements (exceeds 4 allowed).
                Open

                func (c *Cluster) GetTasks(options apitypes.TaskListOptions) ([]types.Task, error) {
                    var r *swarmapi.ListTasksResponse
                
                    err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
                        filterTransform := func(filter filters.Args) error {
                Severity: Major
                Found in daemon/cluster/tasks.go - About 50 mins to fix

                  Method rwlayer.Commit has 8 return statements (exceeds 4 allowed).
                  Open

                  func (rw *rwlayer) Commit() (_ builder.ROLayer, outErr error) {
                      snapshotter := rw.c.SnapshotService(rw.snapshotter)
                  
                      key := stringid.GenerateRandomID()
                  
                  
                  Severity: Major
                  Found in daemon/containerd/image_builder.go - About 50 mins to fix

                    Method Cluster.UnlockSwarm has 8 return statements (exceeds 4 allowed).
                    Open

                    func (c *Cluster) UnlockSwarm(req types.UnlockRequest) error {
                        c.controlMutex.Lock()
                        defer c.controlMutex.Unlock()
                    
                        c.mu.RLock()
                    Severity: Major
                    Found in daemon/cluster/swarm.go - About 50 mins to fix

                      Method Cluster.resolveSystemAddr has 8 return statements (exceeds 4 allowed).
                      Open

                      func (c *Cluster) resolveSystemAddr() (net.IP, error) {
                          // Use the system's only device IP address, or fail if there are
                          // multiple addresses to choose from.
                          interfaces, err := nlwrap.LinkList()
                          if err != nil {
                      Severity: Major
                      Found in daemon/cluster/listen_addr_linux.go - About 50 mins to fix

                        Method reader.readLogs has 8 return statements (exceeds 4 allowed).
                        Open

                        func (r *reader) readLogs(ctx context.Context) {
                            defer close(r.logWatcher.Msg)
                        
                            // Make sure the ready channel is closed in the event of an early
                            // return.
                        Severity: Major
                        Found in daemon/logger/journald/read.go - About 50 mins to fix

                          Method reader.initialSeekTail has 8 return statements (exceeds 4 allowed).
                          Open

                          func (r *reader) initialSeekTail() (bool, error) {
                              var err error
                              if r.config.Until.IsZero() {
                                  err = r.j.SeekTail()
                              } else {
                          Severity: Major
                          Found in daemon/logger/journald/read.go - About 50 mins to fix

                            Method Daemon.setupSecretDir has 8 return statements (exceeds 4 allowed).
                            Open

                            func (daemon *Daemon) setupSecretDir(ctr *container.Container) (setupErr error) {
                                if len(ctr.SecretReferences) == 0 {
                                    return nil
                                }
                            
                            
                            Severity: Major
                            Found in daemon/container_operations_windows.go - About 50 mins to fix

                              Method pluginAdapterWithRead.ReadLogs has 8 return statements (exceeds 4 allowed).
                              Open

                              func (a *pluginAdapterWithRead) ReadLogs(ctx context.Context, config ReadConfig) *LogWatcher {
                                  watcher := NewLogWatcher()
                              
                                  go func() {
                                      defer close(watcher.Msg)
                              Severity: Major
                              Found in daemon/logger/adapter.go - About 50 mins to fix

                                Function ValidateLogOpt has 8 return statements (exceeds 4 allowed).
                                Open

                                func ValidateLogOpt(cfg map[string]string) error {
                                    for key := range cfg {
                                        switch key {
                                        case logGroupKey:
                                        case logStreamKey:
                                Severity: Major
                                Found in daemon/logger/awslogs/cloudwatchlogs.go - About 50 mins to fix

                                  Function ValidateLogOpts has 8 return statements (exceeds 4 allowed).
                                  Open

                                  func ValidateLogOpts(name string, cfg map[string]string) error {
                                      if name == "none" {
                                          return nil
                                      }
                                  
                                  
                                  Severity: Major
                                  Found in daemon/logger/factory.go - About 50 mins to fix

                                    Method Daemon.cleanupContainer has 8 return statements (exceeds 4 allowed).
                                    Open

                                    func (daemon *Daemon) cleanupContainer(container *container.Container, config backend.ContainerRmConfig) error {
                                        if container.IsRunning() {
                                            if !config.ForceRemove {
                                                if state := container.StateString(); state == "paused" {
                                                    return errdefs.Conflict(fmt.Errorf("cannot remove container %q: container is %s and must be unpaused first", container.Name, state))
                                    Severity: Major
                                    Found in daemon/delete.go - About 50 mins to fix

                                      Method Daemon.containerArchivePath has 8 return statements (exceeds 4 allowed).
                                      Open

                                      func (daemon *Daemon) containerArchivePath(container *container.Container, path string) (content io.ReadCloser, stat *containertypes.PathStat, err error) {
                                          container.Lock()
                                      
                                          defer func() {
                                              if err != nil {
                                      Severity: Major
                                      Found in daemon/archive_windows.go - About 50 mins to fix

                                        Method ImageService.ImportImage has 8 return statements (exceeds 4 allowed).
                                        Open

                                        func (i *ImageService) ImportImage(ctx context.Context, newRef reference.Named, platform *ocispec.Platform, msg string, layerReader io.Reader, changes []string) (image.ID, error) {
                                            if platform == nil {
                                                def := platforms.DefaultSpec()
                                                platform = &def
                                            }
                                        Severity: Major
                                        Found in daemon/images/image_import.go - About 50 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language