dotcloud/docker

View on GitHub

Showing 1,898 of 1,898 total issues

Function newROLayerForImage has 5 return statements (exceeds 4 allowed).
Open

func newROLayerForImage(ctx context.Context, imgDesc *ocispec.Descriptor, i *ImageService, platform *ocispec.Platform) (builder.ROLayer, error) {
    if imgDesc == nil {
        return nil, fmt.Errorf("can't make an RO layer for a nil image :'(")
    }

Severity: Major
Found in daemon/containerd/image_builder.go - About 35 mins to fix

    Method containerConfig.setTask has 5 return statements (exceeds 4 allowed).
    Open

    func (c *containerConfig) setTask(t *api.Task, node *api.NodeDescription) error {
        if t.Spec.GetContainer() == nil && t.Spec.GetAttachment() == nil {
            return exec.ErrRuntimeUnsupported
        }
    
    
    Severity: Major
    Found in daemon/cluster/executor/container/container.go - About 35 mins to fix

      Method Cluster.AttachNetwork has 5 return statements (exceeds 4 allowed).
      Open

      func (c *Cluster) AttachNetwork(target string, containerID string, addresses []string) (*network.NetworkingConfig, error) {
          aKey := attacherKey(target, containerID)
          c.mu.Lock()
          state := c.currentNodeState()
          if state.swarmNode == nil || state.swarmNode.Agent() == nil {
      Severity: Major
      Found in daemon/cluster/networks.go - About 35 mins to fix

        Method executor.Describe has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func (e *executor) Describe(ctx context.Context) (*api.NodeDescription, error) {
            info, err := e.backend.SystemInfo(ctx)
            if err != nil {
                return nil, err
            }
        Severity: Minor
        Found in daemon/cluster/executor/container/executor.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method controller.Remove has 5 return statements (exceeds 4 allowed).
        Open

        func (r *controller) Remove(ctx context.Context) error {
            if err := r.checkClosed(); err != nil {
                return err
            }
        
        
        Severity: Major
        Found in daemon/cluster/executor/container/controller.go - About 35 mins to fix

          Method Cluster.CreateVolume has 5 return statements (exceeds 4 allowed).
          Open

          func (c *Cluster) CreateVolume(v volumetypes.CreateOptions) (*volumetypes.Volume, error) {
              var resp *swarmapi.CreateVolumeResponse
              if err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
                  volumeSpec := convert.VolumeCreateToGRPC(&v)
          
          
          Severity: Major
          Found in daemon/cluster/volumes.go - About 35 mins to fix

            Function chownWithCaps has 5 return statements (exceeds 4 allowed).
            Open

            func chownWithCaps(path string, uid int, gid int) error {
                xattrKeys, err := sysx.LListxattr(path)
                if err != nil {
                    return err
                }
            Severity: Major
            Found in daemon/containerd/image_snapshot_unix.go - About 35 mins to fix

              Method Daemon.ContainerTop has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func (daemon *Daemon) ContainerTop(name string, psArgs string) (*container.ContainerTopOKBody, error) {
                  if psArgs == "" {
                      psArgs = "-ef"
                  }
              
              
              Severity: Minor
              Found in daemon/top_unix.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Cluster.GetUnlockKey has 5 return statements (exceeds 4 allowed).
              Open

              func (c *Cluster) GetUnlockKey() (string, error) {
                  var resp *swarmapi.GetUnlockKeyResponse
                  if err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
                      client := swarmapi.NewCAClient(state.grpcConn)
              
              
              Severity: Major
              Found in daemon/cluster/swarm.go - About 35 mins to fix

                Function convertSelector has 5 return statements (exceeds 4 allowed).
                Open

                func convertSelector(ctx context.Context, cc swarmapi.ControlClient, selector *backend.LogSelector) (*swarmapi.LogSelector, error) {
                    // don't rely on swarmkit to resolve IDs, do it ourselves
                    swarmSelector := &swarmapi.LogSelector{}
                    for _, s := range selector.Services {
                        service, err := getService(ctx, cc, s, false)
                Severity: Major
                Found in daemon/cluster/services.go - About 35 mins to fix

                  Method Controller.Start has 5 return statements (exceeds 4 allowed).
                  Open

                  func (p *Controller) Start(ctx context.Context) error {
                      p.logger.Debug("Start")
                  
                      pl, err := p.backend.Get(p.pluginID)
                      if err != nil {
                  Severity: Major
                  Found in daemon/cluster/controllers/plugin/controller.go - About 35 mins to fix

                    Method Cluster.Info has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func (c *Cluster) Info(ctx context.Context) types.Info {
                        info := types.Info{
                            NodeAddr: c.GetAdvertiseAddress(),
                        }
                        c.mu.RLock()
                    Severity: Minor
                    Found in daemon/cluster/swarm.go - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method ImageService.ImagesPrune has 5 return statements (exceeds 4 allowed).
                    Open

                    func (i *ImageService) ImagesPrune(ctx context.Context, fltrs filters.Args) (*image.PruneReport, error) {
                        if !i.pruneRunning.CompareAndSwap(false, true) {
                            return nil, errPruneRunning
                        }
                        defer i.pruneRunning.Store(false)
                    Severity: Major
                    Found in daemon/containerd/image_prune.go - About 35 mins to fix

                      Method rolayer.NewRWLayer has 5 return statements (exceeds 4 allowed).
                      Open

                      func (rl *rolayer) NewRWLayer() (_ builder.RWLayer, outErr error) {
                          snapshotter := rl.c.SnapshotService(rl.snapshotter)
                      
                          key := stringid.GenerateRandomID()
                      
                      
                      Severity: Major
                      Found in daemon/containerd/image_builder.go - About 35 mins to fix

                        Method ImageService.ImageInspect has 5 return statements (exceeds 4 allowed).
                        Open

                        func (i *ImageService) ImageInspect(ctx context.Context, refOrID string, _ backend.ImageInspectOpts) (*imagetypes.InspectResponse, error) {
                            img, err := i.GetImage(ctx, refOrID, backend.GetImageOpts{})
                            if err != nil {
                                return nil, err
                            }
                        Severity: Major
                        Found in daemon/containerd/image_inspect.go - About 35 mins to fix

                          Method ImageService.ImageInspect has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                          Open

                          func (i *ImageService) ImageInspect(ctx context.Context, refOrID string, _ backend.ImageInspectOpts) (*imagetypes.InspectResponse, error) {
                              img, err := i.GetImage(ctx, refOrID, backend.GetImageOpts{})
                              if err != nil {
                                  return nil, err
                              }
                          Severity: Minor
                          Found in daemon/containerd/image_inspect.go - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method Controller.Remove has 5 return statements (exceeds 4 allowed).
                          Open

                          func (p *Controller) Remove(ctx context.Context) error {
                              p.logger.Debug("Remove")
                          
                              pl, err := p.backend.Get(p.pluginID)
                              if err != nil {
                          Severity: Major
                          Found in daemon/cluster/controllers/plugin/controller.go - About 35 mins to fix

                            Method Cluster.CreateNetwork has 5 return statements (exceeds 4 allowed).
                            Open

                            func (c *Cluster) CreateNetwork(s network.CreateRequest) (string, error) {
                                if networkSettings.IsPredefined(s.Name) {
                                    err := notAllowedError(fmt.Sprintf("%s is a pre-defined network and cannot be created", s.Name))
                                    return "", errors.WithStack(err)
                                }
                            Severity: Major
                            Found in daemon/cluster/networks.go - About 35 mins to fix

                              Function validateDefaultAddrPool has 5 return statements (exceeds 4 allowed).
                              Open

                              func validateDefaultAddrPool(defaultAddrPool []string, size uint32) error {
                                  if defaultAddrPool == nil {
                                      // defaultAddrPool is not defined
                                      return nil
                                  }
                              Severity: Major
                              Found in daemon/cluster/listen_addr.go - About 35 mins to fix

                                Method Cluster.GetService has 5 return statements (exceeds 4 allowed).
                                Open

                                func (c *Cluster) GetService(input string, insertDefaults bool) (swarm.Service, error) {
                                    var service *swarmapi.Service
                                    if err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
                                        s, err := getService(ctx, state.controlClient, input, insertDefaults)
                                        if err != nil {
                                Severity: Major
                                Found in daemon/cluster/services.go - About 35 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language