Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/controller.go

Summary

Maintainability
F
5 days
Test Coverage

Method Controller.NewNetwork has a Cognitive Complexity of 79 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Controller) NewNetwork(networkType, name string, id string, options ...NetworkOption) (_ *Network, retErr error) {
    if id != "" {
        c.networkLocker.Lock(id)
        defer c.networkLocker.Unlock(id) //nolint:errcheck
Severity: Minor
Found in libnetwork/controller.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File controller.go has 819 lines of code (exceeds 500 allowed). Consider refactoring.
Open

/*
Package libnetwork provides the basic functionality and extension points to
create network namespaces and allocate interfaces for containers to use.

    networkType := "bridge"
Severity: Major
Found in libnetwork/controller.go - About 1 day to fix

    Method Controller.NewNetwork has 166 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (c *Controller) NewNetwork(networkType, name string, id string, options ...NetworkOption) (_ *Network, retErr error) {
    if id != "" {
        c.networkLocker.Lock(id)
        defer c.networkLocker.Unlock(id) //nolint:errcheck
    Severity: Major
    Found in libnetwork/controller.go - About 5 hrs to fix

      Controller has 39 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type Controller struct {
    id               string
    drvRegistry      drvregistry.Networks
    ipamRegistry     drvregistry.IPAMs
    sandboxes        map[string]*Sandbox
      Severity: Minor
      Found in libnetwork/controller.go - About 5 hrs to fix

        Method Controller.reservePools has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
        Open

        func (c *Controller) reservePools() {
    networks, err := c.getNetworks()
    if err != nil {
        log.G(context.TODO()).Warnf("Could not retrieve networks from local store during ipam allocation for existing networks: %v", err)
        return
        Severity: Minor
        Found in libnetwork/controller.go - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Controller.NewSandbox has 80 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (c *Controller) NewSandbox(ctx context.Context, containerID string, options ...SandboxOption) (_ *Sandbox, retErr error) {
    if containerID == "" {
        return nil, types.InvalidParameterErrorf("invalid container ID")
    }
        Severity: Major
        Found in libnetwork/controller.go - About 2 hrs to fix

          Method Controller.NewNetwork has 20 return statements (exceeds 4 allowed).
          Open

          func (c *Controller) NewNetwork(networkType, name string, id string, options ...NetworkOption) (_ *Network, retErr error) {
    if id != "" {
        c.networkLocker.Lock(id)
        defer c.networkLocker.Unlock(id) //nolint:errcheck
          Severity: Major
          Found in libnetwork/controller.go - About 1 hr to fix

            Method Controller.reservePools has 56 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (c *Controller) reservePools() {
    networks, err := c.getNetworks()
    if err != nil {
        log.G(context.TODO()).Warnf("Could not retrieve networks from local store during ipam allocation for existing networks: %v", err)
        return
            Severity: Minor
            Found in libnetwork/controller.go - About 1 hr to fix

              Method Controller.NewSandbox has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
              Open

              func (c *Controller) NewSandbox(ctx context.Context, containerID string, options ...SandboxOption) (_ *Sandbox, retErr error) {
    if containerID == "" {
        return nil, types.InvalidParameterErrorf("invalid container ID")
    }
              Severity: Minor
              Found in libnetwork/controller.go - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Controller.NewSandbox has 7 return statements (exceeds 4 allowed).
              Open

              func (c *Controller) NewSandbox(ctx context.Context, containerID string, options ...SandboxOption) (_ *Sandbox, retErr error) {
    if containerID == "" {
        return nil, types.InvalidParameterErrorf("invalid container ID")
    }
              Severity: Major
              Found in libnetwork/controller.go - About 45 mins to fix

                Function New has 7 return statements (exceeds 4 allowed).
                Open

                func New(cfgOptions ...config.Option) (*Controller, error) {
    cfg := config.New(cfgOptions...)
    store, err := datastore.New(cfg.Scope)
    if err != nil {
        return nil, fmt.Errorf("libnet controller initialization: %w", err)
                Severity: Major
                Found in libnetwork/controller.go - About 45 mins to fix

                  Method Controller.NetworkByName has 5 return statements (exceeds 4 allowed).
                  Open

                  func (c *Controller) NetworkByName(name string) (*Network, error) {
    if name == "" {
        return nil, ErrInvalidName(name)
    }
    var n *Network
                  Severity: Major
                  Found in libnetwork/controller.go - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    func (c *Controller) loadDriver(networkType string) error {
    var err error

    if pg := c.GetPluginGetter(); pg != nil {
        _, err = pg.Get(networkType, driverapi.NetworkPluginEndpointType, plugingetter.Lookup)
                    Severity: Major
                    Found in libnetwork/controller.go and 1 other location - About 1 hr to fix
                    libnetwork/controller.go on lines 1057..1074

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 164.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    func (c *Controller) loadIPAMDriver(name string) error {
    var err error

    if pg := c.GetPluginGetter(); pg != nil {
        _, err = pg.Get(name, ipamapi.PluginEndpointType, plugingetter.Lookup)
                    Severity: Major
                    Found in libnetwork/controller.go and 1 other location - About 1 hr to fix
                    libnetwork/controller.go on lines 1038..1055

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 164.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    func (c *Controller) isManager() bool {
    c.mu.Lock()
    defer c.mu.Unlock()
    if c.cfg == nil || c.cfg.ClusterProvider == nil {
        return false
                    Severity: Minor
                    Found in libnetwork/controller.go and 1 other location - About 30 mins to fix
                    libnetwork/controller.go on lines 440..447

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 102.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    func (c *Controller) isAgent() bool {
    c.mu.Lock()
    defer c.mu.Unlock()
    if c.cfg == nil || c.cfg.ClusterProvider == nil {
        return false
                    Severity: Minor
                    Found in libnetwork/controller.go and 1 other location - About 30 mins to fix
                    libnetwork/controller.go on lines 431..438

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 102.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status