Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/drivers/overlay/encryption.go

Summary

Maintainability
D
2 days
Test Coverage

File encryption.go has 545 lines of code (exceeds 500 allowed). Consider refactoring.
Open

//go:build linux

package overlay

import (
Severity: Minor
Found in libnetwork/drivers/overlay/encryption.go - About 3 hrs to fix

    Function updateNodeKey has 57 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func updateNodeKey(lIP, aIP, rIP net.IP, idxs []*spi, curKeys []*key, newIdx, priIdx, delIdx int) []*spi {
    log.G(context.TODO()).Debugf("Updating keys for node: %s (%d,%d,%d)", rIP, newIdx, priIdx, delIdx)

    spis := idxs
    log.G(context.TODO()).Debugf("Current: %v", spis)
    Severity: Minor
    Found in libnetwork/drivers/overlay/encryption.go - About 1 hr to fix

      Function programSA has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (fSA *netlink.XfrmState, rSA *netlink.XfrmState, err error) {
    var (
        action      = "Removing"
        xfrmProgram = ns.NlHandle().XfrmStateDel
    )
      Severity: Minor
      Found in libnetwork/drivers/overlay/encryption.go - About 1 hr to fix

        Method driver.programInput has 6 return statements (exceeds 4 allowed).
        Open

        func (d *driver) programInput(vni uint32, add bool) error {
    var (
        plainVxlan = matchVXLAN(overlayutils.VXLANUDPPort(), vni)
        chain      = "INPUT"
        msg        = "add"
        Severity: Major
        Found in libnetwork/drivers/overlay/encryption.go - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

              if (newKey != nil && newIdx == -1) ||
        (primary != nil && priIdx == -1) ||
        (pruneKey != nil && delIdx == -1) {
          Severity: Major
          Found in libnetwork/drivers/overlay/encryption.go - About 40 mins to fix

            Function programSA has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (fSA *netlink.XfrmState, rSA *netlink.XfrmState, err error) {
            Severity: Minor
            Found in libnetwork/drivers/overlay/encryption.go - About 35 mins to fix

              Function programSA has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
              Open

              func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (fSA *netlink.XfrmState, rSA *netlink.XfrmState, err error) {
    var (
        action      = "Removing"
        xfrmProgram = ns.NlHandle().XfrmStateDel
    )
              Severity: Minor
              Found in libnetwork/drivers/overlay/encryption.go - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if dir&forward > 0 {
        fSA = &netlink.XfrmState{
            Src:   localIP,
            Dst:   remoteIP,
            Proto: netlink.XFRM_PROTO_ESP,
              Severity: Major
              Found in libnetwork/drivers/overlay/encryption.go and 1 other location - About 2 hrs to fix
              libnetwork/drivers/overlay/encryption.go on lines 318..342

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 206.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if dir&reverse > 0 {
        rSA = &netlink.XfrmState{
            Src:   remoteIP,
            Dst:   localIP,
            Proto: netlink.XFRM_PROTO_ESP,
              Severity: Major
              Found in libnetwork/drivers/overlay/encryption.go and 1 other location - About 2 hrs to fix
              libnetwork/drivers/overlay/encryption.go on lines 344..368

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 206.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      fSP1 := &netlink.XfrmPolicy{
            Src:     &net.IPNet{IP: s, Mask: fullMask},
            Dst:     &net.IPNet{IP: d, Mask: fullMask},
            Dir:     netlink.XFRM_DIR_OUT,
            Proto:   syscall.IPPROTO_UDP,
              Severity: Major
              Found in libnetwork/drivers/overlay/encryption.go and 1 other location - About 1 hr to fix
              libnetwork/drivers/overlay/encryption.go on lines 396..413

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 168.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  fPol := &netlink.XfrmPolicy{
        Src:     &net.IPNet{IP: s, Mask: fullMask},
        Dst:     &net.IPNet{IP: d, Mask: fullMask},
        Dir:     netlink.XFRM_DIR_OUT,
        Proto:   syscall.IPPROTO_UDP,
              Severity: Major
              Found in libnetwork/drivers/overlay/encryption.go and 1 other location - About 1 hr to fix
              libnetwork/drivers/overlay/encryption.go on lines 610..627

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 168.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func spExists(sp *netlink.XfrmPolicy) (bool, error) {
    _, err := ns.NlHandle().XfrmPolicyGet(sp)
    switch err {
    case nil:
        return true, nil
              Severity: Minor
              Found in libnetwork/drivers/overlay/encryption.go and 1 other location - About 50 mins to fix
              libnetwork/drivers/overlay/encryption.go on lines 430..442

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 122.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func saExists(sa *netlink.XfrmState) (bool, error) {
    _, err := ns.NlHandle().XfrmStateGet(sa)
    switch err {
    case nil:
        return true, nil
              Severity: Minor
              Found in libnetwork/drivers/overlay/encryption.go and 1 other location - About 50 mins to fix
              libnetwork/drivers/overlay/encryption.go on lines 444..456

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 122.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status