Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/ipams/defaultipam/address_space.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method addrSpace.allocatePredefinedPool has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
Open

func (aSpace *addrSpace) allocatePredefinedPool(reserved []netip.Prefix) (netip.Prefix, error) {
    aSpace.mu.Lock()
    defer aSpace.mu.Unlock()

    var pdfID int
Severity: Minor
Found in libnetwork/ipams/defaultipam/address_space.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addrSpace.allocatePredefinedPool has 77 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (aSpace *addrSpace) allocatePredefinedPool(reserved []netip.Prefix) (netip.Prefix, error) {
    aSpace.mu.Lock()
    defer aSpace.mu.Unlock()

    var pdfID int
Severity: Major
Found in libnetwork/ipams/defaultipam/address_space.go - About 2 hrs to fix

    Method addrSpace.allocatePredefinedPool has 10 return statements (exceeds 4 allowed).
    Open

    func (aSpace *addrSpace) allocatePredefinedPool(reserved []netip.Prefix) (netip.Prefix, error) {
    aSpace.mu.Lock()
    defer aSpace.mu.Unlock()

    var pdfID int
    Severity: Major
    Found in libnetwork/ipams/defaultipam/address_space.go - About 1 hr to fix

      Method addrSpace.requestAddress has 5 return statements (exceeds 4 allowed).
      Open

      func (aSpace *addrSpace) requestAddress(nw, sub netip.Prefix, prefAddress netip.Addr, opts map[string]string) (netip.Addr, error) {
    aSpace.mu.Lock()
    defer aSpace.mu.Unlock()

    p, ok := aSpace.subnets[nw]
      Severity: Major
      Found in libnetwork/ipams/defaultipam/address_space.go - About 35 mins to fix

        Method addrSpace.releaseAddress has 5 return statements (exceeds 4 allowed).
        Open

        func (aSpace *addrSpace) releaseAddress(nw, sub netip.Prefix, address netip.Addr) error {
    aSpace.mu.Lock()
    defer aSpace.mu.Unlock()

    p, ok := aSpace.subnets[nw]
        Severity: Major
        Found in libnetwork/ipams/defaultipam/address_space.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status