Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/networkdb/cluster.go

Summary

Maintainability
C
1 day
Test Coverage

File cluster.go has 586 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package networkdb

import (
    "bytes"
    "context"
Severity: Minor
Found in libnetwork/networkdb/cluster.go - About 4 hrs to fix

    Method NetworkDB.bulkSyncNode has 75 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (nDB *NetworkDB) bulkSyncNode(networks []string, node string, unsolicited bool) error {
    var msgs [][]byte

    var unsolMsg string
    if unsolicited {
    Severity: Minor
    Found in libnetwork/networkdb/cluster.go - About 2 hrs to fix

      Method NetworkDB.clusterInit has 65 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (nDB *NetworkDB) clusterInit() error {
    nDB.lastStatsTimestamp = time.Now()
    nDB.lastHealthTimestamp = nDB.lastStatsTimestamp

    config := memberlist.DefaultLANConfig()
      Severity: Minor
      Found in libnetwork/networkdb/cluster.go - About 1 hr to fix

        Method NetworkDB.gossip has 58 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (nDB *NetworkDB) gossip() {
    networkNodes := make(map[string][]string)
    nDB.RLock()
    thisNodeNetworks := nDB.networks[nDB.config.NodeID]
    for nid := range thisNodeNetworks {
        Severity: Minor
        Found in libnetwork/networkdb/cluster.go - About 1 hr to fix

          Method NetworkDB.gossip has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
          Open

          func (nDB *NetworkDB) gossip() {
    networkNodes := make(map[string][]string)
    nDB.RLock()
    thisNodeNetworks := nDB.networks[nDB.config.NodeID]
    for nid := range thisNodeNetworks {
          Severity: Minor
          Found in libnetwork/networkdb/cluster.go - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method NetworkDB.bulkSyncNode has 6 return statements (exceeds 4 allowed).
          Open

          func (nDB *NetworkDB) bulkSyncNode(networks []string, node string, unsolicited bool) error {
    var msgs [][]byte

    var unsolMsg string
    if unsolicited {
          Severity: Major
          Found in libnetwork/networkdb/cluster.go - About 40 mins to fix

            Method NetworkDB.clusterInit has 5 return statements (exceeds 4 allowed).
            Open

            func (nDB *NetworkDB) clusterInit() error {
    nDB.lastStatsTimestamp = time.Now()
    nDB.lastHealthTimestamp = nDB.lastStatsTimestamp

    config := memberlist.DefaultLANConfig()
            Severity: Major
            Found in libnetwork/networkdb/cluster.go - About 35 mins to fix

              Method NetworkDB.bulkSyncTables has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func (nDB *NetworkDB) bulkSyncTables() {
    var networks []string
    nDB.RLock()
    for nid, network := range nDB.networks[nDB.config.NodeID] {
        if network.leaving {
              Severity: Minor
              Found in libnetwork/networkdb/cluster.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status