Sign upLogin

dotcloud/docker

View on GitHub
Star
libnetwork/portallocator/portallocator.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method PortAllocator.RequestPortsInRange has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func (p *PortAllocator) RequestPortsInRange(ips []net.IP, proto string, portStart, portEnd int) (int, error) {
    if proto != "tcp" && proto != "udp" && proto != "sctp" {
        return 0, ErrUnknownProtocol
    }
Severity: Minor
Found in libnetwork/portallocator/portallocator.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PortAllocator.RequestPortsInRange has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *PortAllocator) RequestPortsInRange(ips []net.IP, proto string, portStart, portEnd int) (int, error) {
    if proto != "tcp" && proto != "udp" && proto != "sctp" {
        return 0, ErrUnknownProtocol
    }
Severity: Minor
Found in libnetwork/portallocator/portallocator.go - About 1 hr to fix

    Method PortAllocator.RequestPortsInRange has 7 return statements (exceeds 4 allowed).
    Open

    func (p *PortAllocator) RequestPortsInRange(ips []net.IP, proto string, portStart, portEnd int) (int, error) {
    if proto != "tcp" && proto != "udp" && proto != "sctp" {
        return 0, ErrUnknownProtocol
    }
    Severity: Major
    Found in libnetwork/portallocator/portallocator.go - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status