Sign upLogin

dotcloud/docker

View on GitHub
Star
registry/search.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method Service.Search has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func (s *Service) Search(ctx context.Context, searchFilters filters.Args, term string, limit int, authConfig *registry.AuthConfig, headers map[string][]string) ([]registry.SearchResult, error) {
    if err := searchFilters.Validate(acceptedSearchFilterTags); err != nil {
        return nil, err
    }
Severity: Minor
Found in registry/search.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Service.Search has 7 return statements (exceeds 4 allowed).
Open

func (s *Service) Search(ctx context.Context, searchFilters filters.Args, term string, limit int, authConfig *registry.AuthConfig, headers map[string][]string) ([]registry.SearchResult, error) {
    if err := searchFilters.Validate(acceptedSearchFilterTags); err != nil {
        return nil, err
    }
Severity: Major
Found in registry/search.go - About 45 mins to fix

    Method Service.Search has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (s *Service) Search(ctx context.Context, searchFilters filters.Args, term string, limit int, authConfig *registry.AuthConfig, headers map[string][]string) ([]registry.SearchResult, error) {
    Severity: Minor
    Found in registry/search.go - About 45 mins to fix

      Method Service.searchUnfiltered has 6 return statements (exceeds 4 allowed).
      Open

      func (s *Service) searchUnfiltered(ctx context.Context, term string, limit int, authConfig *registry.AuthConfig, headers http.Header) (*registry.SearchResults, error) {
    // TODO Use ctx when searching for repositories
    if hasScheme(term) {
        return nil, invalidParamf("invalid repository name: repository name (%s) should not have a scheme", term)
    }
      Severity: Major
      Found in registry/search.go - About 40 mins to fix

        Method Service.searchUnfiltered has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (s *Service) searchUnfiltered(ctx context.Context, term string, limit int, authConfig *registry.AuthConfig, headers http.Header) (*registry.SearchResults, error) {
        Severity: Minor
        Found in registry/search.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status