Sign upLogin

dtaniwaki/e2e-tester

View on GitHub
Star

Showing 259 of 259 total issues

Method scan_file has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def scan_file(path)
        return [] unless path =~ %r{(views)/(.+/[^_/][^./]+)[^/]+$}
        relative_path = "#{Regexp.last_match(1)}/#{Regexp.last_match(2)}"
        return [] if Regexp.last_match(2).start_with?('layouts')
        return [] if Regexp.last_match(2) =~ /[_]?mailer\b/
Severity: Minor
Found in lib/i18n_tasks/page_title_scanner.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method driver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def driver(_credential = nil)
      browser_name = browser.to_sym
      caps = {}
      case browser_name
      when :phantomjs
Severity: Minor
Found in app/models/browser/local.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method serialized_attribute has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def serialized_attribute(*names)
      options = names.extract_options!
      names.each do |name|
        name = name.to_s
        serialized_attribute_keys << name
Severity: Minor
Found in app/models/concerns/serialized_attribute.rb - About 1 hr to fix

    Method validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def validate(record)
    conditions = [options[:conditions] || []].flatten
    count = options[:count] || 1
    message = options[:message] || I18n.t(:too_many_similar_records, default: 'Too many similar records')
    Severity: Minor
    Found in lib/validators/similar_record_validator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method driver has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def driver(_credential = nil)
      browser_name = browser.to_sym
      caps = {}
      case browser_name
      when :phantomjs
    Severity: Minor
    Found in app/models/browser/local.rb - About 1 hr to fix

      Method update_source has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.update_source
      browsers = [
        {
          browser: 'phantomjs',
          device: 'desktop'
      Severity: Minor
      Found in app/models/browser/local.rb - About 1 hr to fix

        Method execute! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def execute!(driver, variables = {})
    running!
    begin
      test_step.execute!(self, driver, variables)
      self.message = nil
        Severity: Minor
        Found in app/models/test_step_execution.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method send_notification! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def send_notification!
    executer_test = nil
    test.user_tests.preload(user: :user_integrations).find_each do |ut|
      if ut.user == user
        executer_test = ut
        Severity: Minor
        Found in app/models/test_execution.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def update
    @user_test_version = UserTestVersion.find(params[:id])
    authorize @user_test_version

    if @user_test_version.update_attributes(permitted_params)
        Severity: Minor
        Found in app/controllers/user_test_versions_controller.rb and 1 other location - About 55 mins to fix
        app/controllers/user_tests_controller.rb on lines 22..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def update
    @user_test = UserTest.find(params[:id])
    authorize @user_test

    if @user_test.update_attributes(permitted_params)
        Severity: Minor
        Found in app/controllers/user_tests_controller.rb and 1 other location - About 55 mins to fix
        app/controllers/user_test_versions_controller.rb on lines 22..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def translate(key, options = {})
    options = options.dup
    options[:raise] = true
    if key.to_s !~ /^(devise|simple_form|activerecord|models|active_admin)/
      options[:scope] = ['views']
        Severity: Minor
        Found in app/helpers/i18n_helper.rb and 1 other location - About 50 mins to fix
        app/controllers/concerns/i18n_concern.rb on lines 4..13

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def translate(key, options = {})
    options = options.dup
    options[:raise] = true
    if key.to_s !~ /^(devise|simple_form|activerecord|models)/
      options[:scope] = ['controllers']
        Severity: Minor
        Found in app/controllers/concerns/i18n_concern.rb and 1 other location - About 50 mins to fix
        app/helpers/i18n_helper.rb on lines 2..11

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        rack-cors Gem Missing Anchor permits unauthorized CORS requests
        Open

            rack-cors (0.4.0)
        Severity: Critical
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2017-11173

        Criticality: High

        URL: https://github.com/cyu/rack-cors/issues/86

        Solution: upgrade to >= 0.4.1

        Possible shell escape sequence injection vulnerability in Rack
        Open

            rack (2.0.1)
        Severity: Minor
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2022-30123

        Criticality: Critical

        URL: https://groups.google.com/g/ruby-security-ann/c/LWB10kWzag8

        Solution: upgrade to >= 2.0.9.1, ~> 2.0.9, >= 2.1.4.1, ~> 2.1.4, >= 2.2.3.1

        File Content Disclosure in Action View
        Open

            actionview (5.0.1)
        Severity: Critical
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2019-5418

        Criticality: High

        URL: https://groups.google.com/forum/#!topic/rubyonrails-security/pFRKI96Sm8Q

        Solution: upgrade to >= 4.2.11.1, ~> 4.2.11, >= 5.0.7.2, ~> 5.0.7, >= 5.1.6.2, ~> 5.1.6, >= 5.2.2.1, ~> 5.2.2, >= 6.0.0.beta3

        Path traversal is possible via backslash characters on Windows.
        Open

            rack-protection (1.5.3)
        Severity: Minor
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2018-7212

        URL: https://github.com/sinatra/sinatra/pull/1379

        Solution: upgrade to >= 2.0.1, ~> 1.5.4

        Nokogiri gem contains two upstream vulnerabilities in libxslt 1.1.29
        Open

            nokogiri (1.7.0.1)
        Severity: Critical
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2017-5029

        Criticality: High

        URL: https://github.com/sparklemotion/nokogiri/issues/1634

        Solution: upgrade to >= 1.7.2

        Nokogiri gem contains several vulnerabilities in libxml2 and libxslt
        Open

            nokogiri (1.7.0.1)
        Severity: Minor
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2016-4658

        Criticality: Critical

        URL: https://github.com/sparklemotion/nokogiri/issues/1615

        Solution: upgrade to >= 1.7.1

        Directory traversal vulnerability in rubyzip
        Open

            rubyzip (1.2.0)
        Severity: Minor
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2017-5946

        Criticality: Critical

        URL: https://github.com/rubyzip/rubyzip/issues/315

        Solution: upgrade to >= 1.2.1

        XSS vulnerability in rails-html-sanitizer
        Open

            rails-html-sanitizer (1.0.3)
        Severity: Minor
        Found in Gemfile.lock by bundler-audit

        Advisory: CVE-2018-3741

        URL: https://groups.google.com/d/msg/rubyonrails-security/tP7W3kLc5u4/uDy2Br7xBgAJ

        Solution: upgrade to >= 1.0.4

        Severity
        Category
        Status
        Source
        Language