dunkelfrosch/phpcoverfish

View on GitHub
src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php

Summary

Maintainability
C
1 day
Test Coverage

BaseCoverFishValidator has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class BaseCoverFishValidator implements BaseCoverFishValidatorInterface
{
    /**
     * @var ArrayCollection
     */
Severity: Minor
Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 3 hrs to fix

    File BaseCoverFishValidator.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace DF\PHPCoverFish\Validator\Base;
    
    use DF\PHPCoverFish\Common\ArrayCollection;
    Severity: Minor
    Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 2 hrs to fix

      Method validateReflectionClassForAccessorVisibility has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function validateReflectionClassForAccessorVisibility($classFQN, $accessor)
          {
              $reflectionClass = $this->getReflectionClass($classFQN);
              if ($reflectionClass instanceof CoverFishMessageError) {
                  return $reflectionClass;
      Severity: Minor
      Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 1 hr to fix

        Function validateReflectionClassForAccessorVisibility has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function validateReflectionClassForAccessorVisibility($classFQN, $accessor)
            {
                $reflectionClass = $this->getReflectionClass($classFQN);
                if ($reflectionClass instanceof CoverFishMessageError) {
                    return $reflectionClass;
        Severity: Minor
        Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status