Sign upLogin

e-sabelhaus/prestige

View on GitHub
Star

Showing 20 of 20 total issues

proto has 49 functions (exceeds 20 allowed). Consider refactoring.
Open

var proto = {
    version: packageJson.version
    , JSONStringify: JSONStringify
    , setApiKey: function(k){ this.apiKey = k; return this; }
    , getApiKey: function(){ return this.apiKey; }
Severity: Minor
Found in src/node-promised-redmine/redmine.js - About 6 hrs to fix

    Function request has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        , request: function(method, path, params){
        params || (params = {});

        var self = this
            , d = D()
    Severity: Major
    Found in src/node-promised-redmine/redmine.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            tracking.updateIssue(tracking_config, project, postCommit, key, function(res, err) {
        if (!err) {
          response.writeHead(200);
          response.end("Tracking: Attempting Issue Update!\n" + res);
        } else {
      Severity: Major
      Found in lib/prestige/routes/index.js and 1 other location - About 3 hrs to fix
      lib/prestige/routes/index.js on lines 42..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            ci.startBuild(ci_config, postCommit, job, key, function(res, err) {
        if (!err) {
          response.writeHead(200);
          response.end("CI: Attempting Build!\n" + res);
        } else {
      Severity: Major
      Found in lib/prestige/routes/index.js and 1 other location - About 3 hrs to fix
      lib/prestige/routes/index.js on lines 24..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File redmine.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*jshint strict:false, node:true, indent:false, forin:false, bitwise:false*/
/*global JSON*/
var http = require('http')
    , https = require('https')
    , querystring = require('querystring')
      Severity: Minor
      Found in src/node-promised-redmine/redmine.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (config && key){
      config.apiKey = key;
      var redmineApi = new Redmine(config);
      redmineApi.getProjects()
      .success(function(projects){
        Severity: Major
        Found in lib/prestige/tracking.js and 1 other location - About 1 hr to fix
        lib/prestige/tracking.js on lines 69..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (config && key) {
      config.apiKey = key;
      var redmineApi = new Redmine(config);
      redmineApi.getIssues()
      .success(function(issues){
        Severity: Major
        Found in lib/prestige/tracking.js and 1 other location - About 1 hr to fix
        lib/prestige/tracking.js on lines 85..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function startBuild has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          exports.startBuild = function(config, data, job, key, callback) {
    if (config && job && key) {
      log = config.logger;
      log.debug("CI#startBuild", data);
      var buildPath = config.protocol + '://' +
        Severity: Minor
        Found in lib/prestige/ci.js - About 1 hr to fix

          Function exports has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(grunt) {
  grunt.initConfig({
    pkg: grunt.file.readJSON('package.json'),
    jshint: {
      // define the files to lint
          Severity: Minor
          Found in Gruntfile.js - About 1 hr to fix

            Function exports has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              module.exports = function(nconf, log) {
    var tracking_config = nconf.get('prestidigitation:tracking');
    tracking_config.logger = log;

    var ci_config = nconf.get('prestidigitation:ci');
            Severity: Minor
            Found in lib/prestige/routes/index.js - About 1 hr to fix

              Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                module.exports = function(log_lvl){
    var log = bunyan.createLogger({
      name: 'Prestige',
      streams: [
        {
              Severity: Minor
              Found in lib/prestige/util/logger.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (config && projectID && key){
      log = config.logger;
      log.debug("Tracking#updateIssue", data);
      config.apiKey = key;
      var redmineApi = new Redmine(config);
                Severity: Major
                Found in lib/prestige/tracking.js and 1 other location - About 1 hr to fix
                lib/prestige/ci.js on lines 21..66

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (config && job && key) {
      log = config.logger;
      log.debug("CI#startBuild", data);
      var buildPath = config.protocol + '://' +
                      config.host + '/buildByToken/build?job=' +
                Severity: Major
                Found in lib/prestige/ci.js and 1 other location - About 1 hr to fix
                lib/prestige/tracking.js on lines 19..43

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    ,updateTimeEntry: function(id, timeEntry, params){
        params || (params = {});
        params.time_entry = timeEntry;
        return this.put('time_entries/' + id, params);
    }
                Severity: Minor
                Found in src/node-promised-redmine/redmine.js and 1 other location - About 50 mins to fix
                src/node-promised-redmine/redmine.js on lines 289..293

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    , updateIssue: function(id, issue, params) {
        params || (params = {});
        params.issue = issue;
        return this.put('issues/' + id, params);
    }
                Severity: Minor
                Found in src/node-promised-redmine/redmine.js and 1 other location - About 50 mins to fix
                src/node-promised-redmine/redmine.js on lines 319..323

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    , request: function(method, path, params){
        params || (params = {});

        var self = this
            , d = D()
                Severity: Minor
                Found in src/node-promised-redmine/redmine.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function updateIssue has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  exports.updateIssue = function(config, projectID, data, key, callback) {
                Severity: Minor
                Found in lib/prestige/tracking.js - About 35 mins to fix

                  Function startBuild has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    exports.startBuild = function(config, data, job, key, callback) {
                  Severity: Minor
                  Found in lib/prestige/ci.js - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        , postIssue: function(issue, params) {
        params || (params = {});
        params.issue = issue;
        return this.post('issues', params);
    }
                    Severity: Minor
                    Found in src/node-promised-redmine/redmine.js and 1 other location - About 35 mins to fix
                    src/node-promised-redmine/redmine.js on lines 314..318

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        ,postTimeEntry: function(timeEntry, params){
        params || (params = {});
        params.time_entry = timeEntry;
        return this.post('time_entries', params);
    }
                    Severity: Minor
                    Found in src/node-promised-redmine/redmine.js and 1 other location - About 35 mins to fix
                    src/node-promised-redmine/redmine.js on lines 284..288

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language