Sign upLogin

ecadlabs/signatory

View on GitHub
Star
pkg/utils/utils.go

Summary

Maintainability
C
7 hrs
Test Coverage
C
73%

Function ParseMap has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func ParseMap(s string, namevalSep, tuplesSep rune) (res map[string]string, err error) {
    res = make(map[string]string)
    p := []byte(s)
    for {
        p, err = eatSpace(p)
Severity: Minor
Found in pkg/utils/utils.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ParseMap has 64 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ParseMap(s string, namevalSep, tuplesSep rune) (res map[string]string, err error) {
    res = make(map[string]string)
    p := []byte(s)
    for {
        p, err = eatSpace(p)
Severity: Minor
Found in pkg/utils/utils.go - About 1 hr to fix

    Function ParseMap has 13 return statements (exceeds 4 allowed).
    Open

    func ParseMap(s string, namevalSep, tuplesSep rune) (res map[string]string, err error) {
    res = make(map[string]string)
    p := []byte(s)
    for {
        p, err = eatSpace(p)
    Severity: Major
    Found in pkg/utils/utils.go - About 1 hr to fix

      Function readString has 5 return statements (exceeds 4 allowed).
      Open

      func readString(p []byte, end rune) (rem []byte, out string, err error) {
    r, sz := utf8.DecodeRune(p)
    if r == utf8.RuneError {
        return nil, "", errRune
    }
      Severity: Major
      Found in pkg/utils/utils.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status