ecadlabs/signatory

View on GitHub
pkg/vault/azure/azure.go

Summary

Maintainability
D
2 days
Test Coverage
F
47%

Method azureIterator.Next has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
Open

func (a *azureIterator) Next() (key vault.StoredKey, err error) {
    if a.done {
        return nil, vault.ErrDone
    }

Severity: Minor
Found in pkg/vault/azure/azure.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method azureIterator.Next has 72 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (a *azureIterator) Next() (key vault.StoredKey, err error) {
    if a.done {
        return nil, vault.ErrDone
    }

Severity: Minor
Found in pkg/vault/azure/azure.go - About 1 hr to fix

    Method azureIterator.Next has 11 return statements (exceeds 4 allowed).
    Open

    func (a *azureIterator) Next() (key vault.StoredKey, err error) {
        if a.done {
            return nil, vault.ErrDone
        }
    
    
    Severity: Major
    Found in pkg/vault/azure/azure.go - About 1 hr to fix

      Method Vault.Import has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (v *Vault) Import(ctx context.Context, priv crypt.PrivateKey, opt utils.Options) (vault.StoredKey, error) {
          keyName, ok, err := opt.GetString("name")
          if err != nil {
              return nil, fmt.Errorf("(Azure/%s): %w", v.config.Vault, err)
          }
      Severity: Minor
      Found in pkg/vault/azure/azure.go - About 1 hr to fix

        Method Vault.Import has 9 return statements (exceeds 4 allowed).
        Open

        func (v *Vault) Import(ctx context.Context, priv crypt.PrivateKey, opt utils.Options) (vault.StoredKey, error) {
            keyName, ok, err := opt.GetString("name")
            if err != nil {
                return nil, fmt.Errorf("(Azure/%s): %w", v.config.Vault, err)
            }
        Severity: Major
        Found in pkg/vault/azure/azure.go - About 55 mins to fix

          Method Vault.SignMessage has 8 return statements (exceeds 4 allowed).
          Open

          func (v *Vault) SignMessage(ctx context.Context, message []byte, key vault.StoredKey) (crypt.Signature, error) {
              digest := crypt.DigestFunc(message)
              azureKey, ok := key.(*azureKey)
              if !ok {
                  return nil, errors.Wrap(fmt.Errorf("(Azure/%s): not a Azure key: %T", v.config.Vault, key), http.StatusBadRequest)
          Severity: Major
          Found in pkg/vault/azure/azure.go - About 50 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if err != nil {
                                    return nil, fmt.Errorf("(Azure/%s): %w", a.v.config.Vault, err)
                                }
            Severity: Major
            Found in pkg/vault/azure/azure.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if status != 0 {
                                      err = errors.Wrap(err, status)
                                  }
              Severity: Major
              Found in pkg/vault/azure/azure.go - About 45 mins to fix

                Method Vault.request has 7 return statements (exceeds 4 allowed).
                Open

                func (v *Vault) request(ctx context.Context, client *http.Client, method, url string, body io.Reader, result interface{}) (status int, err error) {
                    req, err := http.NewRequestWithContext(ctx, method, url, body)
                    if err != nil {
                        return status, err
                    }
                Severity: Major
                Found in pkg/vault/azure/azure.go - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if u == "" {
                                          a.done = true
                                          return nil, vault.ErrDone
                                      }
                  Severity: Major
                  Found in pkg/vault/azure/azure.go - About 45 mins to fix

                    Method Vault.request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (v *Vault) request(ctx context.Context, client *http.Client, method, url string, body io.Reader, result interface{}) (status int, err error) {
                    Severity: Minor
                    Found in pkg/vault/azure/azure.go - About 35 mins to fix

                      Method Vault.GetPublicKey has 5 return statements (exceeds 4 allowed).
                      Open

                      func (v *Vault) GetPublicKey(ctx context.Context, keyID string) (vault.StoredKey, error) {
                          u, err := v.makeURL(keyID, "")
                          if err != nil {
                              return nil, fmt.Errorf("(Azure/%s): %w", v.config.Vault, err)
                          }
                      Severity: Major
                      Found in pkg/vault/azure/azure.go - About 35 mins to fix

                        Method Vault.Ready has 5 return statements (exceeds 4 allowed).
                        Open

                        func (v *Vault) Ready(ctx context.Context) (bool, error) {
                            if v.managementClient == nil {
                                return true, nil // ignore
                            }
                        
                        
                        Severity: Major
                        Found in pkg/vault/azure/azure.go - About 35 mins to fix

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                          func init() {
                              vault.RegisterVault("azure", func(ctx context.Context, node *yaml.Node) (vault.Vault, error) {
                                  var conf Config
                                  if node == nil || node.Kind == 0 {
                                      return nil, errors.New("(Azure): config is missing")
                          Severity: Major
                          Found in pkg/vault/azure/azure.go and 4 other locations - About 1 hr to fix
                          pkg/vault/aws/awskms.go on lines 172..188
                          pkg/vault/cloudkms/cloudkms.go on lines 399..415
                          pkg/vault/hashicorp/vault.go on lines 60..76
                          pkg/vault/yubi/yubi.go on lines 421..437

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 182.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status