ecadlabs/signatory

Method HSM.Import has 7 return statements (exceeds 4 allowed).

Open

func (h *HSM) Import(ctx context.Context, pk crypt.PrivateKey, opt utils.Options) (vault.StoredKey, error) {
    typ, alg, caps, p, err := getPrivateKeyData(pk)
    if err != nil {
        return nil, fmt.Errorf("(YubiHSM/%s): %w", h.conf.id(), err)
    }

Method yubihsmStoredKeysIterator.Next has 7 return statements (exceeds 4 allowed).

Open

func (y *yubihsmStoredKeysIterator) Next() (key vault.StoredKey, err error) {
    if y.objects == nil {
        y.objects, err = y.hsm.listObjects(commands.NewObjectTypeOption(commands.ObjectTypeAsymmetricKey))
        if err != nil {
            return nil, fmt.Errorf("(YubiHSM/%s): %w", y.hsm.conf.id(), err)

Function parsePublicKey has 7 return statements (exceeds 4 allowed).

Open

func parsePublicKey(r *commands.GetPubKeyResponse) (crypt.PublicKey, bool, error) {
    switch r.Algorithm {
    case commands.AlgorithmP256, commands.AlgorithmSecp256k1:
        var curve elliptic.Curve
        switch r.Algorithm {

Method HSM.GetPublicKey has 7 return statements (exceeds 4 allowed).

Open

func (h *HSM) GetPublicKey(ctx context.Context, keyID string) (vault.StoredKey, error) {
    id, err := strconv.ParseUint(keyID, 16, 16)
    if err != nil {
        return nil, fmt.Errorf("(YubiHSM/%s): %w", h.conf.id(), err)
    }

Method HSM.signED25519 has 5 return statements (exceeds 4 allowed).

Open

func (h *HSM) signED25519(digest []byte, id uint16) (crypt.Ed25519Signature, error) {
    command, err := commands.CreateSignDataEddsaCommand(id, digest)
    if err != nil {
        return nil, fmt.Errorf("(YubiHSM/%s): %w", h.conf.id(), err)
    }

Method HSM.signECDSA has 5 return statements (exceeds 4 allowed).

Open

func (h *HSM) signECDSA(digest []byte, id uint16, curve elliptic.Curve) (*crypt.ECDSASignature, error) {
    command, err := commands.CreateSignDataEcdsaCommand(id, digest)
    if err != nil {
        return nil, fmt.Errorf("(YubiHSM/%s): %w", h.conf.id(), err)
    }

Method HSM.Ready has 5 return statements (exceeds 4 allowed).

Open

func (h *HSM) Ready(ctx context.Context) (bool, error) {
    command, err := commands.CreateEchoCommand(echoMessage)
    if err != nil {
        return false, fmt.Errorf("(YubiHSM/%s): %w", h.conf.id(), err)
    }

Similar blocks of code found in 5 locations. Consider refactoring.

Open

func init() {
    vault.RegisterVault("yubihsm", func(ctx context.Context, node *yaml.Node) (vault.Vault, error) {
        var conf Config
        if node == nil || node.Kind == 0 {
            return nil, errors.New("(YubiHSM): config is missing")

• Read up
  Read up