edgewall/trac

View on GitHub

Showing 1,372 of 1,372 total issues

Avoid deeply nested control flow statements.
Open

                        if arg == 'inline':
                            inline = True
                        elif arg == 'unnumbered':
                            numbered = False

Severity: Major
Found in trac/wiki/macros.py - About 45 mins to fix

    Function _format_link has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _format_link(self, formatter, ns, pagename, label, ignore_missing,
    Severity: Minor
    Found in trac/wiki/api.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if os.path.isfile(filename):
                                  self._import(filename, page, replace)
                      else:
      Severity: Major
      Found in trac/wiki/admin.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if diffs:
                                    has_diffs = True
                                # elif None (means: manually compare to (previous))
                                show_entry = True
        Severity: Major
        Found in trac/versioncontrol/web_ui/changeset.py - About 45 mins to fix

          Function _macro_formatter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def _macro_formatter(self, match, fullmatch, macro, only_inline=False):
                  name = fullmatch.group('macroname')
                  if name and name[-1] == '?': # Macro?() shortcut for MacroList(Macro)
                      args = name[:-1] or '*'
                  else:
          Severity: Minor
          Found in trac/wiki/formatter.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  if hasattr(macro_provider, 'expand_macro'):
                                      self.processor = self._macro_processor
                                  else:
                                      raise TracError(
                                          tag_("Pre-0.11 macros with the %(method)s "
          Severity: Major
          Found in trac/wiki/formatter.py - About 45 mins to fix

            Function emit_linebreak has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def emit_linebreak(self, args):
                    if args:
                        sep = ':' if ':' in args else '='
                        kv = args.split(sep, 1)
                        if kv[0] == 'clear':
            Severity: Minor
            Found in trac/wiki/formatter.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                    if v < version:
                                        if not prev_version:
                                            prev_version = v
                                            break
                                    else:
            Severity: Major
            Found in trac/wiki/web_ui.py - About 45 mins to fix

              Function export_page has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def export_page(self, page, filename):
                      wikipage = model.WikiPage(self.env, page)
                      if wikipage.exists:
                          if not filename:
                              printout(wikipage.text)
              Severity: Minor
              Found in trac/wiki/admin.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _prepare_diff has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def _prepare_diff(self, req, page, old_text, new_text,
              Severity: Minor
              Found in trac/wiki/web_ui.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if repos.has_node(path, next_rev):
                                            next_href = req.href.changeset(next_rev, reponame,
                                                                           path)
                                        else:  # must be 'D'elete or 'R'ename, show full cset
                                            next_href = req.href.changeset(next_rev, reponame)
                Severity: Major
                Found in trac/versioncontrol/web_ui/changeset.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if len(flag) > 1:
                                          keys.append(str(flag[1:]))
                                          values.append(False)
                                  else:
                  Severity: Major
                  Found in trac/wiki/parser.py - About 45 mins to fix

                    Function _make_lhref_link has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def _make_lhref_link(self, match, fullmatch, rel, ns, target, label):
                    Severity: Minor
                    Found in trac/wiki/formatter.py - About 45 mins to fix

                      Function daemonize has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def daemonize(pidfile=None, progname=None, stdin='/dev/null',
                      Severity: Minor
                      Found in trac/util/daemon.py - About 45 mins to fix

                        Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def __init__(self, safe_schemes=SAFE_SCHEMES, safe_css=SAFE_CSS,
                        Severity: Minor
                        Found in trac/util/html.py - About 45 mins to fix

                          Function appendrange has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def appendrange(self, r):
                                  """Add ranges to the current one.
                          
                                  A range is specified as a string of the form "low-high", and
                                  `r` can be a list of such strings, a string containing comma-separated
                          Severity: Minor
                          Found in trac/util/__init__.py - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid deeply nested control flow statements.
                          Open

                                                  if action not in req.perm:
                                                      add_warning(req,
                                                                  _("The permission %(action)s was "
                                                                    "not granted to %(subject)s "
                                                                    "because users cannot grant "
                          Severity: Major
                          Found in trac/admin/web_ui.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if l.territory:
                                                        locale = l
                                                        break
                                                except (UnknownLocaleError, ValueError):
                            Severity: Major
                            Found in trac/util/datefmt.py - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if kwarg_name in func_kwargs_map:
                                                          messages_kwargs[kwarg_name] = message
                                                      else:
                                                          messages.append(message)
                                                      del buf[:]
                              Severity: Major
                              Found in trac/dist.py - About 45 mins to fix

                                Function wrap has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                def wrap(t, cols=75, initial_indent='', subsequent_indent='',
                                Severity: Minor
                                Found in trac/util/text.py - About 45 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language