File ClientV2.php has 493 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @file
* Contains \Educa\DSB\Client\ApiClient\ClientV2.ClientV2 has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class ClientV2 extends AbstractClient
{
protected $tokenExpiresOn;
Method authenticate has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function authenticate()
{
if (!file_exists($this->privateKeyPath)) {
throw new ClientAuthenticationException("Private key could not be loaded. Is the path correct ?");
}Method postDescription has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function postDescription($json, $catalogs = array(), $previewImage = false)
{
if (empty($this->tokenKey)) {
throw new ClientAuthenticationException("No token found. Cannot create a LOM description without a token.");
}Function postDescription has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function postDescription($json, $catalogs = array(), $previewImage = false)
{
if (empty($this->tokenKey)) {
throw new ClientAuthenticationException("No token found. Cannot create a LOM description without a token.");
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getPartner has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getPartner($partner = null)
{
if (empty($this->tokenKey)) {
throw new ClientAuthenticationException("No token found. Cannot load a partner without a token.");
}Method getPartnerStatistics has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getPartnerStatistics(
$partnerId,
$from,
$to,
$aggregationMethod = 'day',Method search has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function search(
$query = '',
array $useFacets = [],
array $filters = [],
array $additionalFields = [],Method putDescription has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function putDescription($id, $json, $catalogs = array())
{
if (empty($this->tokenKey)) {
throw new ClientAuthenticationException("No token found. Cannot update a LOM description without a token.");
}Function authenticate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function authenticate()
{
if (!file_exists($this->privateKeyPath)) {
throw new ClientAuthenticationException("Private key could not be loaded. Is the path correct ?");
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getPartnerStatistics has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
$partnerId,
$from,
$to,
$aggregationMethod = 'day',
$lomId = null,Method search has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
$query = '',
array $useFacets = [],
array $filters = [],
array $additionalFields = [],
$offset = 0,Method loadPartnerStatistics has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
$partnerId,
$from,
$to,
$aggregationMethod = 'day',
$lomId = null,Function putDescription has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function putDescription($id, $json, $catalogs = array())
{
if (empty($this->tokenKey)) {
throw new ClientAuthenticationException("No token found. Cannot update a LOM description without a token.");
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getPartnerStatistics has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function getPartnerStatistics(
$partnerId,
$from,
$to,
$aggregationMethod = 'day',- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getPartner has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getPartner($partner = null)
{
if (empty($this->tokenKey)) {
throw new ClientAuthenticationException("No token found. Cannot load a partner without a token.");
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 3 locations. Consider refactoring. Open
try {
$response = $this->get('/suggest', $options);
if ($response->getStatusCode() == 200) {
return json_decode($response->getBody(), true);
} else {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 138.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
try {
$response = $this->get('/search', $options);
if ($response->getStatusCode() == 200) {
return json_decode($response->getBody(), true);
} else {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 138.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
try {
$response = $this->post('/description', $params);
if ($response->getStatusCode() == 200) {
return json_decode($response->getBody(), true);
} else {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 138.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76