Showing 78 of 223 total issues
File MissionListTest.php
has 624 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* User: JC
* Date: 2016-11-18
- Create a ticketCreate a ticket
Function imageInfo
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
public function imageInfo(array $files, $width = 0): array
{
if (empty($files)) {
return [];
}
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File MissionTest.php
has 309 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* User: JC
* Date: 2016-11-28
- Create a ticketCreate a ticket
CrewMember
has 25 functions (exceeds 20 allowed). Consider refactoring. Open
class CrewMember extends Model implements Hyperlink
{
/**
* Member name, also used in generating URI & page
*
- Create a ticketCreate a ticket
Function parseStep
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function parseStep(string $text): array
{
$columns = [
'steptitle' => 'name',
'choice' => 'alt',
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method testNew
has 68 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function testNew()
{
$api = $this->newApiInstance();
$text = (file_get_contents(
static::DIR_SAMPLE . '/Crew-crew_member_list.txt'
- Create a ticketCreate a ticket
MissionListTest
has 24 functions (exceeds 20 allowed). Consider refactoring. Open
class MissionListTest extends TestCase
{
private $wiki;
/**
- Create a ticketCreate a ticket
Method checkCadetAdvMissionSteps
has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function checkCadetAdvMissionSteps(MissionModel $model)
{
$this->checkMissionStep(
$model->steps[0],
[
- Create a ticketCreate a ticket
Method checkCadetMissionSteps
has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function checkCadetMissionSteps(MissionModel $model)
{
$this->checkMissionStep(
$model->steps[0],
[
- Create a ticketCreate a ticket
File MissionList.php
has 274 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* User: JC
* Date: 2016-11-17
- Create a ticketCreate a ticket
Method parseStepProp
has 64 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function parseStepProp(
string $key,
string $values,
string $advValues
) {
- Create a ticketCreate a ticket
File Mission.php
has 266 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* User: JC
* Date: 2016-11-20
- Create a ticketCreate a ticket
Function mapTraits
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
private function mapTraits(array $traits): array
{
$ret = [];
foreach ($traits as $index => $list) {
if (empty($list)) {
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function parseStepProp
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function parseStepProp(
string $key,
string $values,
string $advValues
) {
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parseStep
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function parseStep(string $text): array
{
$columns = [
'steptitle' => 'name',
'choice' => 'alt',
- Create a ticketCreate a ticket
File CrewList.php
has 251 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* User: JC
* Date: 2016-10-23
- Create a ticketCreate a ticket
Method checkCadetAdvStep3
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function checkCadetAdvStep3(Mission $model)
{
$step = $model->steps[2];
$this->assertInstanceOf(MissionStep::class, $step);
$this->assertCount(2, $step->skills);
- Create a ticketCreate a ticket
Method checkCadetStep3
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function checkCadetStep3(Mission $model)
{
$step = $model->steps[2];
$this->assertInstanceOf(MissionStep::class, $step);
$this->assertCount(2, $step->skills);
- Create a ticketCreate a ticket
Function skillValue
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
public function skillValue(string $table, array $skills): ?array
{
$regex = '/^\s*\|\s*\d+\s*$(.+?)\|[}-].*?$/imsu';
if (!preg_match_all($regex, $table, $levels)) {
return null;
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method imageInfo
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function imageInfo(array $files, $width = 0): array
{
if (empty($files)) {
return [];
}
- Create a ticketCreate a ticket