Sign upLogin

ekristen/gcp-nuke

View on GitHub
Star

Showing 55 of 55 total issues

Method ComputeSecurityPolicy.HandleWait has 5 return statements (exceeds 4 allowed).
Open

func (r *ComputeSecurityPolicy) HandleWait(ctx context.Context) error {
    if r.removeOp == nil {
        return nil
    }
Severity: Major
Found in resources/compute-security-policy.go - About 35 mins to fix

    Method ComputeBackendService.HandleWait has 5 return statements (exceeds 4 allowed).
    Open

    func (r *ComputeBackendService) HandleWait(ctx context.Context) error {
    if r.removeOp == nil {
        return nil
    }
    Severity: Major
    Found in resources/compute-backend-service.go - About 35 mins to fix

      Method VPCIPAddress.HandleWait has 5 return statements (exceeds 4 allowed).
      Open

      func (r *VPCIPAddress) HandleWait(ctx context.Context) error {
    if r.removeOp == nil {
        return nil
    }
      Severity: Major
      Found in resources/vpc-ip-address.go - About 35 mins to fix

        Method IAMServiceAccountKeyLister.List has 5 return statements (exceeds 4 allowed).
        Open

        func (l *IAMServiceAccountKeyLister) List(ctx context.Context, o interface{}) ([]resource.Resource, error) {
    var resources []resource.Resource

    opts := o.(*nuke.ListerOpts)
    if err := opts.BeforeList(nuke.Global, "iam.googleapis.com"); err != nil {
        Severity: Major
        Found in resources/iam-service-account-key.go - About 35 mins to fix

          Method ComputeURLMap.HandleWait has 5 return statements (exceeds 4 allowed).
          Open

          func (r *ComputeURLMap) HandleWait(ctx context.Context) error {
    if r.removeOp == nil {
        return nil
    }
          Severity: Major
          Found in resources/compute-url-map.go - About 35 mins to fix

            Method ComputeTargetHTTPProxy.HandleWait has 5 return statements (exceeds 4 allowed).
            Open

            func (r *ComputeTargetHTTPProxy) HandleWait(ctx context.Context) error {
    if r.removeOp == nil {
        return nil
    }
            Severity: Major
            Found in resources/compute-target-http-proxy.go - About 35 mins to fix

              Method DNSManagedZoneLister.List has 5 return statements (exceeds 4 allowed).
              Open

              func (l *DNSManagedZoneLister) List(ctx context.Context, o interface{}) ([]resource.Resource, error) {
    opts := o.(*nuke.ListerOpts)
    var resources []resource.Resource

    if err := opts.BeforeList(nuke.Global, "dns.googleapis.com"); err != nil {
              Severity: Major
              Found in resources/dns-managed-zone.go - About 35 mins to fix

                Method IAMWorkloadIdentityPoolProviderLister.List has 5 return statements (exceeds 4 allowed).
                Open

                func (l *IAMWorkloadIdentityPoolProviderLister) List(ctx context.Context, o interface{}) ([]resource.Resource, error) {
    var resources []resource.Resource

    opts := o.(*nuke.ListerOpts)
    if err := opts.BeforeList(nuke.Global, "iam.googleapis.com"); err != nil {
                Severity: Major
                Found in resources/iam-workload-identity-pool-provider.go - About 35 mins to fix

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  func (r *VPCRouter) Remove(ctx context.Context) error {
    _, err := r.svc.Delete(ctx, &computepb.DeleteRouterRequest{
        Project: *r.Project,
        Region:  *r.Region,
        Router:  *r.Name,
                  Severity: Major
                  Found in resources/vpc-router.go and 4 other locations - About 30 mins to fix
                  resources/compute-disk.go on lines 103..110
                  resources/compute-instance.go on lines 93..100
                  resources/compute-packet-mirroring.go on lines 84..91
                  resources/vpc-subnet.go on lines 109..116

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  func (r *ComputeDisk) Remove(ctx context.Context) error {
    _, err := r.svc.Delete(ctx, &computepb.DeleteDiskRequest{
        Project: *r.project,
        Zone:    *r.Zone,
        Disk:    *r.Name,
                  Severity: Major
                  Found in resources/compute-disk.go and 4 other locations - About 30 mins to fix
                  resources/compute-instance.go on lines 93..100
                  resources/compute-packet-mirroring.go on lines 84..91
                  resources/vpc-router.go on lines 83..90
                  resources/vpc-subnet.go on lines 109..116

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  func (r *ComputePacketMirroring) Remove(ctx context.Context) error {
    _, err := r.svc.Delete(ctx, &computepb.DeletePacketMirroringRequest{
        Project:         *r.project,
        Region:          *r.region,
        PacketMirroring: *r.Name,
                  Severity: Major
                  Found in resources/compute-packet-mirroring.go and 4 other locations - About 30 mins to fix
                  resources/compute-disk.go on lines 103..110
                  resources/compute-instance.go on lines 93..100
                  resources/vpc-router.go on lines 83..90
                  resources/vpc-subnet.go on lines 109..116

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  func (r *ComputeInstance) Remove(ctx context.Context) error {
    _, err := r.svc.Delete(ctx, &computepb.DeleteInstanceRequest{
        Project:  *r.Project,
        Zone:     *r.Zone,
        Instance: *r.Name,
                  Severity: Major
                  Found in resources/compute-instance.go and 4 other locations - About 30 mins to fix
                  resources/compute-disk.go on lines 103..110
                  resources/compute-packet-mirroring.go on lines 84..91
                  resources/vpc-router.go on lines 83..90
                  resources/vpc-subnet.go on lines 109..116

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  func (r *VPCSubnet) Remove(ctx context.Context) error {
    _, err := r.svc.Delete(ctx, &computepb.DeleteSubnetworkRequest{
        Project:    *r.project,
        Region:     *r.region,
        Subnetwork: *r.Name,
                  Severity: Major
                  Found in resources/vpc-subnet.go and 4 other locations - About 30 mins to fix
                  resources/compute-disk.go on lines 103..110
                  resources/compute-instance.go on lines 93..100
                  resources/compute-packet-mirroring.go on lines 84..91
                  resources/vpc-router.go on lines 83..90

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 100.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function execute has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func execute(c *cli.Context) error {
    ctx, cancel := context.WithCancel(c.Context)
    defer cancel()

    gcp, err := gcputil.New(ctx, c.String("project-id"), c.String("impersonate-service-account"))
                  Severity: Minor
                  Found in pkg/commands/run/command.go - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function New has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func New(ctx context.Context, projectID, impersonateServiceAccount string) (*GCP, error) {
    gcp := &GCP{
        Organizations: make([]*Organization, 0),
        Projects:      make([]*Project, 0),
        Regions:       []string{"global"},
                  Severity: Minor
                  Found in pkg/gcputil/gcp.go - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language