Sign upLogin

elboletaire/Watimage

View on GitHub
Star
src/Image.php

Summary

Maintainability
D
2 days
Test Coverage

File Image.php has 604 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace Elboletaire\Watimage;

use Exception;
use Elboletaire\Watimage\Exception\ExtensionNotLoadedException;
Severity: Major
Found in src/Image.php - About 1 day to fix

    Image has 50 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
    Severity: Minor
    Found in src/Image.php - About 7 hrs to fix

      The class Image has 37 public methods. Consider refactoring Image to keep number of public methods under 10.
      Open

      class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
      Severity: Minor
      Found in src/Image.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      The class Image has 42 non-getter- and setter-methods. Consider refactoring Image to keep number of methods under 25.
      Open

      class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
      Severity: Minor
      Found in src/Image.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      The class Image has an overall complexity of 123 which is very high. The configured complexity threshold is 50.
      Open

      class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
      Severity: Minor
      Found in src/Image.php by phpmd

      Method convenienceFlip has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function convenienceFlip($type = 'horizontal')
    {
        $type = Normalize::flip($type);

        $resampled = $this->imagecreate($this->width, $this->height);
      Severity: Minor
      Found in src/Image.php - About 1 hr to fix

        Method imagecopy has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function imagecopy($dstW, $dstH, $srcX = 0, $srcY = 0, $srcW = false, $srcH = false)
        Severity: Minor
        Found in src/Image.php - About 45 mins to fix

          Method calculateCropMeasures has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function calculateCropMeasures($croppedFile, $ox, $oy = null, $dx = null, $dy = null)
          Severity: Minor
          Found in src/Image.php - About 35 mins to fix

            Method vignetteEffect has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                protected function vignetteEffect($size, $level, $x, $y, &$rgb)
            Severity: Minor
            Found in src/Image.php - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $this->rotate(90);
              Severity: Major
              Found in src/Image.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $this;
                Severity: Major
                Found in src/Image.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $this->rotate(-90);
                  Severity: Major
                  Found in src/Image.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return $this->rotate(-90);
                    Severity: Major
                    Found in src/Image.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return $this->rotate(90);
                      Severity: Major
                      Found in src/Image.php - About 30 mins to fix

                        Function generate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function generate($filename = null, $output = null, $header = true)
    {
        $output = $output ?: $this->metadata['mime'];
        if (!empty($filename)) {
            $output = $this->getMimeFromExtension($filename);
                        Severity: Minor
                        Found in src/Image.php - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        The class Image has 1192 lines of code. Current threshold is 1000. Avoid really long classes.
                        Open

                        class Image
{
    /**
     * Constant for the (deprecated) transparent color
     */
                        Severity: Minor
                        Found in src/Image.php by phpmd

                        TODO found
                        Open

                             * TODO: Create an additional class with instagram-like effects and move it there.
                        Severity: Minor
                        Found in src/Image.php by fixme

                        Avoid variables with short names like $oy. Configured minimum length is 3.
                        Open

                            public function calculateCropMeasures($croppedFile, $ox, $oy = null, $dx = null, $dy = null)
                        Severity: Minor
                        Found in src/Image.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $dx. Configured minimum length is 3.
                        Open

                            public function calculateCropMeasures($croppedFile, $ox, $oy = null, $dx = null, $dy = null)
                        Severity: Minor
                        Found in src/Image.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $ox. Configured minimum length is 3.
                        Open

                            public function calculateCropMeasures($croppedFile, $ox, $oy = null, $dx = null, $dy = null)
                        Severity: Minor
                        Found in src/Image.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $dy. Configured minimum length is 3.
                        Open

                            public function calculateCropMeasures($croppedFile, $ox, $oy = null, $dx = null, $dy = null)
                        Severity: Minor
                        Found in src/Image.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        Avoid variables with short names like $l. Configured minimum length is 3.
                        Open

                                $l = sin(M_PI / $this->width * $x) * sin(M_PI / $this->height * $y);
                        Severity: Minor
                        Found in src/Image.php by phpmd

                        ShortVariable

                        Since: 0.2

                        Detects when a field, local, or parameter has a very short name.

                        Example

                        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                        Source https://phpmd.org/rules/naming.html#shortvariable

                        There are no issues that match your filters.

                        Category
                        Status