elder-orm/core

View on GitHub

Showing 31 of 31 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  static updateSome(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateSome'.
Severity: Major
Found in src/classes/model.ts and 1 other location - About 1 day to fix
src/classes/model.ts on lines 401..423

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 285.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  static updateOne(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateOne'.
Severity: Major
Found in src/classes/model.ts and 1 other location - About 1 day to fix
src/classes/model.ts on lines 363..385

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 285.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File model.ts has 515 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Adapter from './adapter'
import Serializer from './serializer'
import Type from './type'
import Base from './base'
import Collection from './collection'
Severity: Major
Found in src/classes/model.ts - About 1 day to fix

    Model has 47 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export default class Model extends Base {
      static idField: string = 'id'
      static adapter: Adapter
      static serializers: serializers
      static meta: modelMeta = {
    Severity: Minor
    Found in src/classes/model.ts - About 6 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        static deleteSome(where: props): Promise<number> {
          for (const prop of Reflect.ownKeys(where)) {
            if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
              throw new Error(`
                Invalid key '${prop}' defined on 'where' given to 'Model.deleteSome'.
      Severity: Major
      Found in src/classes/model.ts and 2 other locations - About 6 hrs to fix
      src/classes/model.ts on lines 331..343
      src/classes/model.ts on lines 349..361

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        static deleteOne(where: props): Promise<number> {
          for (const prop of Reflect.ownKeys(where)) {
            if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
              throw new Error(`
                Invalid key '${prop}' defined on 'where' given to 'Model.deleteOne'.
      Severity: Major
      Found in src/classes/model.ts and 2 other locations - About 6 hrs to fix
      src/classes/model.ts on lines 317..329
      src/classes/model.ts on lines 349..361

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        static updateAll(props: props): Promise<number> {
          for (const prop of Reflect.ownKeys(props)) {
            if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
              throw new Error(`
                Invalid key '${prop}' defined on 'props' given to 'Model.updateAll'.
      Severity: Major
      Found in src/classes/model.ts and 2 other locations - About 6 hrs to fix
      src/classes/model.ts on lines 317..329
      src/classes/model.ts on lines 331..343

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 159.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      PostgresAdapter has 30 functions (exceeds 20 allowed). Consider refactoring.
      Open

      export default class PostgresAdapter extends Adapter {
        knex: Knex
      
        constructor(config: databaseConfig) {
          super(config)
      Severity: Minor
      Found in src/adapters/postgres.ts - About 3 hrs to fix

        Adapter has 24 functions (exceeds 20 allowed). Consider refactoring.
        Open

        export default class Adapter {
          config: databaseConfig
        
          constructor(config: databaseConfig) {
            this.config = config
        Severity: Minor
        Found in src/classes/adapter.ts - About 2 hrs to fix

          File postgres.ts has 269 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import Adapter, {
            DatabaseConnectionError,
            databaseConfig,
            optsMultiple,
            optsSingle,
          Severity: Minor
          Found in src/adapters/postgres.ts - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              static get modelName(): string {
                if (this._modelName) return this._modelName
                const nameWithoutModel = this.name.replace('Model', '').toLowerCase()
                const nameUnderscored = underscore(nameWithoutModel)
                const nameDasherized = dasherize(nameUnderscored)
            Severity: Major
            Found in src/classes/model.ts and 1 other location - About 2 hrs to fix
            src/classes/model.ts on lines 160..166

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              static get plural(): string {
                if (this._plural) return this._plural
                const nameWithoutModel = this.name.replace('Model', '').toLowerCase()
                const nameUnderscored = underscore(nameWithoutModel)
                const nameDasherized = dasherize(nameUnderscored)
            Severity: Major
            Found in src/classes/model.ts and 1 other location - About 2 hrs to fix
            src/classes/model.ts on lines 183..189

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              modify(value: boolean | number | string, options: options): boolean {
                if (['true', 'TRUE', 'T', 't', '1', 1, true].includes(value)) {
                  return true
                } else if (['false', 'FALSE', 'F', 'f', '0', 0, false].includes(value)) {
                  return false
            Severity: Major
            Found in src/types/boolean.ts and 1 other location - About 1 hr to fix
            src/types/boolean.ts on lines 29..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              retrieve(value: string | number | boolean, options: options): boolean {
                if (['true', 'TRUE', 'T', 't', '1', 1, true].includes(value)) {
                  return true
                } else if (['false', 'FALSE', 'F', 'f', '0', 0, false].includes(value)) {
                  return false
            Severity: Major
            Found in src/types/boolean.ts and 1 other location - About 1 hr to fix
            src/types/boolean.ts on lines 15..23

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function type has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export default function type(
              typeName: string,
              options?: { [name: string]: any }
            ): (target: Model, propertyKey: string) => void {
              return function typeDecorator(target: any, propertyKey: string): void {
            Severity: Minor
            Found in src/decorators/type.ts - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  for (const [key, value] of Object.entries(this.meta.attributes)) {
                    if (value && value.default) {
                      defaults[key] = value.default
                    }
                  }
              Severity: Major
              Found in src/classes/model.ts and 1 other location - About 1 hr to fix
              src/classes/model.ts on lines 303..307

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      for (const [key, value] of Object.entries(this.meta.attributes)) {
                        if (value && value.default) {
                          defaults[key] = value.default
                        }
                      }
              Severity: Major
              Found in src/classes/model.ts and 1 other location - About 1 hr to fix
              src/classes/model.ts on lines 274..278

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function typeDecorator has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                return function typeDecorator(target: any, propertyKey: string): void {
                  const Ctor = target.constructor as typeof Model
              
                  const instance: any = Ctor.create()
                  if (instance[propertyKey]) {
              Severity: Minor
              Found in src/decorators/type.ts - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                function mergeSerializers(
                  defaultSerializer: typeof Serializer,
                  serializers?: {
                    [name: string]: typeof Serializer
                  }
                Severity: Major
                Found in src/classes/elder.ts and 1 other location - About 1 hr to fix
                src/classes/elder.ts on lines 71..78

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                function mergeAdapters(
                  defaultAdapter: typeof Adapter,
                  adapters?: {
                    [name: string]: typeof Adapter
                  }
                Severity: Major
                Found in src/classes/elder.ts and 1 other location - About 1 hr to fix
                src/classes/elder.ts on lines 83..90

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language