Sign upLogin

elder-orm/core

View on GitHub
Star

Showing 31 of 31 total issues

Function createSome has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static async createSome(records: props[]): Promise<number> {
    for (let [index, props] of records.entries()) {
      for (const prop of Reflect.ownKeys(props)) {
        if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
          throw new Error(`
Severity: Minor
Found in src/classes/model.ts - About 1 hr to fix

    Function defineId has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static defineId() {
    const Ctor = this
    Reflect.defineProperty(this.prototype, Ctor.idField, {
      get() {
        const that: any = this
    Severity: Minor
    Found in src/classes/model.ts - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export type optsMultiple = {
  include?: string | string[]
  sort?: string
  fields?: string[]
  limit?: number
      Severity: Minor
      Found in src/classes/model.ts and 1 other location - About 50 mins to fix
      src/classes/adapter.ts on lines 135..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export type optsMultiple = {
  include?: string | string[]
  sort?: string
  fields?: string[]
  limit?: number
      Severity: Minor
      Found in src/classes/adapter.ts and 1 other location - About 50 mins to fix
      src/classes/model.ts on lines 532..538

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        updateSome(Ctor: typeof Model, where: where, props: props): Promise<number> {
    return Promise.resolve(0)
  }
      Severity: Minor
      Found in src/classes/adapter.ts and 1 other location - About 45 mins to fix
      src/classes/adapter.ts on lines 106..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        updateOne(Ctor: typeof Model, where: where, props: props): Promise<number> {
    return Promise.resolve(0)
  }
      Severity: Minor
      Found in src/classes/adapter.ts and 1 other location - About 45 mins to fix
      src/classes/adapter.ts on lines 98..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function type(
  typeName: string,
  options?: { [name: string]: any }
): (target: Model, propertyKey: string) => void {
  return function typeDecorator(target: any, propertyKey: string): void {
      Severity: Minor
      Found in src/decorators/type.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createOne has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        static async createOne<T extends typeof Model>(
    this: T,
    props: props
  ): Promise<T['prototype']> {
    for (const prop of Reflect.ownKeys(props)) {
      Severity: Minor
      Found in src/classes/model.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateSome has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        static updateSome(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateSome'.
      Severity: Minor
      Found in src/classes/model.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateOne has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        static updateOne(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateOne'.
      Severity: Minor
      Found in src/classes/model.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createSome has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        static async createSome(records: props[]): Promise<number> {
    for (let [index, props] of records.entries()) {
      for (const prop of Reflect.ownKeys(props)) {
        if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
          throw new Error(`
      Severity: Minor
      Found in src/classes/model.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language