Sign upLogin

elder-orm/core

View on GitHub
Star
src/classes/model.ts

Summary

Maintainability
F
1 wk
Test Coverage

File model.ts has 515 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Adapter from './adapter'
import Serializer from './serializer'
import Type from './type'
import Base from './base'
import Collection from './collection'
Severity: Major
Found in src/classes/model.ts - About 1 day to fix

    Model has 47 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export default class Model extends Base {
  static idField: string = 'id'
  static adapter: Adapter
  static serializers: serializers
  static meta: modelMeta = {
    Severity: Minor
    Found in src/classes/model.ts - About 6 hrs to fix

      Function createSome has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static async createSome(records: props[]): Promise<number> {
    for (let [index, props] of records.entries()) {
      for (const prop of Reflect.ownKeys(props)) {
        if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
          throw new Error(`
      Severity: Minor
      Found in src/classes/model.ts - About 1 hr to fix

        Function defineId has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static defineId() {
    const Ctor = this
    Reflect.defineProperty(this.prototype, Ctor.idField, {
      get() {
        const that: any = this
        Severity: Minor
        Found in src/classes/model.ts - About 1 hr to fix

          Function createOne has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            static async createOne<T extends typeof Model>(
    this: T,
    props: props
  ): Promise<T['prototype']> {
    for (const prop of Reflect.ownKeys(props)) {
          Severity: Minor
          Found in src/classes/model.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateSome has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            static updateSome(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateSome'.
          Severity: Minor
          Found in src/classes/model.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateOne has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            static updateOne(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateOne'.
          Severity: Minor
          Found in src/classes/model.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createSome has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            static async createSome(records: props[]): Promise<number> {
    for (let [index, props] of records.entries()) {
      for (const prop of Reflect.ownKeys(props)) {
        if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
          throw new Error(`
          Severity: Minor
          Found in src/classes/model.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            static updateSome(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateSome'.
          Severity: Major
          Found in src/classes/model.ts and 1 other location - About 1 day to fix
          src/classes/model.ts on lines 401..423

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 285.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            static updateOne(where: props, props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.updateOne'.
          Severity: Major
          Found in src/classes/model.ts and 1 other location - About 1 day to fix
          src/classes/model.ts on lines 363..385

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 285.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            static deleteSome(where: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.deleteSome'.
          Severity: Major
          Found in src/classes/model.ts and 2 other locations - About 6 hrs to fix
          src/classes/model.ts on lines 331..343
          src/classes/model.ts on lines 349..361

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 159.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            static deleteOne(where: props): Promise<number> {
    for (const prop of Reflect.ownKeys(where)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'where' given to 'Model.deleteOne'.
          Severity: Major
          Found in src/classes/model.ts and 2 other locations - About 6 hrs to fix
          src/classes/model.ts on lines 317..329
          src/classes/model.ts on lines 349..361

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 159.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            static updateAll(props: props): Promise<number> {
    for (const prop of Reflect.ownKeys(props)) {
      if (!Reflect.ownKeys(this.meta.types).includes(prop)) {
        throw new Error(`
          Invalid key '${prop}' defined on 'props' given to 'Model.updateAll'.
          Severity: Major
          Found in src/classes/model.ts and 2 other locations - About 6 hrs to fix
          src/classes/model.ts on lines 317..329
          src/classes/model.ts on lines 331..343

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 159.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            static get modelName(): string {
    if (this._modelName) return this._modelName
    const nameWithoutModel = this.name.replace('Model', '').toLowerCase()
    const nameUnderscored = underscore(nameWithoutModel)
    const nameDasherized = dasherize(nameUnderscored)
          Severity: Major
          Found in src/classes/model.ts and 1 other location - About 2 hrs to fix
          src/classes/model.ts on lines 160..166

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            static get plural(): string {
    if (this._plural) return this._plural
    const nameWithoutModel = this.name.replace('Model', '').toLowerCase()
    const nameUnderscored = underscore(nameWithoutModel)
    const nameDasherized = dasherize(nameUnderscored)
          Severity: Major
          Found in src/classes/model.ts and 1 other location - About 2 hrs to fix
          src/classes/model.ts on lines 183..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              for (const [key, value] of Object.entries(this.meta.attributes)) {
      if (value && value.default) {
        defaults[key] = value.default
      }
    }
          Severity: Major
          Found in src/classes/model.ts and 1 other location - About 1 hr to fix
          src/classes/model.ts on lines 303..307

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (const [key, value] of Object.entries(this.meta.attributes)) {
          if (value && value.default) {
            defaults[key] = value.default
          }
        }
          Severity: Major
          Found in src/classes/model.ts and 1 other location - About 1 hr to fix
          src/classes/model.ts on lines 274..278

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          export type optsMultiple = {
  include?: string | string[]
  sort?: string
  fields?: string[]
  limit?: number
          Severity: Minor
          Found in src/classes/model.ts and 1 other location - About 50 mins to fix
          src/classes/adapter.ts on lines 135..141

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status