Sign upLogin

elephantly/AmpConverterBundle

View on GitHub
Star
Converter/Social/AmpFacebookIframeConverter.php

Summary

Maintainability
A
30 mins
Test Coverage

Avoid too many return statements within this method.
Open

                return null;
Severity: Major
Found in Converter/Social/AmpFacebookIframeConverter.php - About 30 mins to fix

    Define a constant instead of duplicating this literal "height" 3 times.
    Open

            $this->mandatoryAttributes = array('layout', 'data-href', 'height', 'width');
    Severity: Critical
    Found in Converter/Social/AmpFacebookIframeConverter.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "data-href" 3 times.
    Open

            $this->attributes = array('data-href', 'data-embed-as');
    Severity: Critical
    Found in Converter/Social/AmpFacebookIframeConverter.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "width" 3 times.
    Open

            $this->mandatoryAttributes = array('layout', 'data-href', 'height', 'width');
    Severity: Critical
    Found in Converter/Social/AmpFacebookIframeConverter.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

        }
    Severity: Minor
    Found in Converter/Social/AmpFacebookIframeConverter.php by phpcodesniffer

    The closing brace for the class must go on the next line after the body
    Open

    }
    Severity: Minor
    Found in Converter/Social/AmpFacebookIframeConverter.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status