Sign upLogin

elephantly/AmpConverterBundle

View on GitHub
Star
DependencyInjection/Configuration.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getConfigTreeBuilder has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('elephantly_amp_converter');
Severity: Minor
Found in DependencyInjection/Configuration.php - About 1 hr to fix

    Define a constant instead of duplicating this literal "scalar" 3 times.
    Open

                        ->prototype('scalar')
    Severity: Critical
    Found in DependencyInjection/Configuration.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    There are no issues that match your filters.

    Category
    Status