kahlan-config.travis.php
Define a constant instead of duplicating this literal "coverage" 5 times. Open
Open
$commandLine->option('coverage', 'default', 3);
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Expected 1 space after FUNCTION keyword; 0 found Open
Open
Filter::register('kahlan.coverage-exporter', function($chain) {
- Exclude checks
Expected 1 space after FUNCTION keyword; 0 found Open
Open
Filter::register('kahlan.coverage', function($chain) {
- Exclude checks