Sign upLogin

elisei/pagbank-payment-magento

View on GitHub
Star

Showing 159 of 159 total issues

Function getPreOrderData has 45 lines of code (exceeds 40 allowed). Consider refactoring.
Open

        getPreOrderData(
            cardPayData
        ) {
            var totalAmount = parseFloat(quote.totals()['base_grand_total']) * 100,
                customerEmail = quote.guestEmail ? quote.guestEmail : window.checkoutConfig.customerData.email,
Severity: Minor
Found in view/base/web/js/model/pagbank-pre-order-data.js - About 1 hr to fix

    Method getPagBankInstallments has 44 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

        public function getPagBankInstallments($storeId, $creditCardBin, $amount, $cardTypeTransaction = 'CREDIT_CARD')
    {
        /** @var LaminasClient $client */
        $client = $this->httpClientFactory->create();
        $url = $this->configBase->getApiUrl($storeId);
    Severity: Minor
    Found in Model/Api/ConsultPSInstallments.php - About 1 hr to fix

      Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              TypeListInterface $cacheTypeList,
        Pool $cacheFrontendPool,
        Logger $logger,
        State $state,
        ScopeConfigInterface $scopeConfig,
      Severity: Major
      Found in Model/Console/Command/Basic/Refresh.php - About 1 hr to fix

        Method execute has 43 lines of code (exceeds 40 allowed). Consider refactoring.
        Open

            public function execute()
    {
        $configDefault = false;

        $params = $this->getRequest()->getParams();
        Severity: Minor
        Found in Controller/Adminhtml/System/Config/Oauth.php - About 1 hr to fix

          Function execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute()
    {
        $configDefault = false;

        $params = $this->getRequest()->getParams();
          Severity: Minor
          Found in Controller/Adminhtml/System/Config/Oauth.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function validate(array $validationSubject): ResultInterface
    {
        $response = SubjectReader::readResponse($validationSubject);

        $isValid = $response['RESULT_CODE'];
          Severity: Minor
          Found in Gateway/Validator/GeneralResponseValidator.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Context $context,
        TypeListInterface $cacheTypeList,
        Pool $cacheFrontendPool,
        JsonFactory $resultJsonFactory,
        ConfigInterface $configInterface,
          Severity: Major
          Found in Controller/Adminhtml/System/Config/Logout.php - About 1 hr to fix

            Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    CommandPoolInterface $commandPool,
        BuilderInterface $requestBuilder,
        TransferFactoryInterface $transferFactory,
        ClientInterface $client,
        LoggerInterface $logger,
            Severity: Major
            Found in Gateway/Command/PaymentCommand.php - About 1 hr to fix

              Function newToken has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function newToken($storeId = null)
    {
        $storeIds = $storeId ?: null;
        $this->writeln('Init Referesh Token');
        $inDefault = $this->getConfigInDefault();
              Severity: Minor
              Found in Model/Console/Command/Basic/Refresh.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method aroundAddButton has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      View $subject,
        \Closure $proceed,
        string $buttonId,
        array $data,
        int $level = 0,
              Severity: Major
              Found in Plugin/SalesOrderViewButtonPlugin.php - About 50 mins to fix

                Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        Context $context,
        TypeListInterface $cacheTypeList,
        Pool $cacheFrontendPool,
        JsonFactory $resultJsonFactory,
        StoreManagerInterface $storeManager,
                Severity: Major
                Found in Controller/Adminhtml/System/Config/Oauth.php - About 50 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getCreditCardType(string $type): ?string
    {
        $type = strtoupper($type);
        $mapper = $this->configCc->getCcTypesMapper();
                  Severity: Minor
                  Found in Gateway/Response/TxnDataCcHandler.php and 1 other location - About 50 mins to fix
                  Gateway/Response/VaultDetailsHandler.php on lines 231..237

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getCreditCardType(string $type): ?string
    {
        $type = strtoupper($type);
        $mapper = $this->configCc->getCcTypesMapper();
                  Severity: Minor
                  Found in Gateway/Response/VaultDetailsHandler.php and 1 other location - About 50 mins to fix
                  Gateway/Response/TxnDataCcHandler.php on lines 281..287

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function generatePagBankInterest has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function generatePagBankInterest(
        $cartId,
        CreditCardBinInterface $creditCardBin,
        InstallmentSelectedInterface $installmentSelected
    ) {
                  Severity: Minor
                  Found in Model/Api/InterestManagement.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function isThreeDsApplicable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function isThreeDsApplicable(\Magento\Checkout\Model\Cart $cart, $storeId = null): bool
    {
        $quote = $cart->getQuote();

        if (!$this->hasThreeDsAuth($storeId)) {
                  Severity: Minor
                  Found in Gateway/Config/ConfigCc.php - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          Config $resourceConfig,
        EncryptorInterface $encryptor,
        StoreManagerInterface $storeManager,
        ConfigBase $configBase,
        ClientFactory $httpClientFactory,
                  Severity: Minor
                  Found in Model/Api/Credential.php - About 45 mins to fix

                    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            ConfigBase $configBase,
        ConfigCc $configCc,
        Cart $cart,
        CcConfig $ccConfig,
        Source $assetSource,
                    Severity: Minor
                    Found in Model/Ui/ConfigProviderCc.php - About 45 mins to fix

                      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              \Magento\Backend\Block\Context $context,
        \Magento\Backend\Model\Auth\Session $authSession,
        \Magento\Framework\View\Helper\Js $jsHelper,
        \Magento\Config\Model\Config $backendConfig,
        SecureHtmlRenderer $secureRenderer,
                      Severity: Minor
                      Found in Model/Adminhtml/Source/PaymentGroup.php - About 45 mins to fix

                        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                ConfigDeepLink $config,
        CartInterface $cart,
        CcConfig $ccConfig,
        Escaper $escaper,
        Source $assetSource
                        Severity: Minor
                        Found in Model/Ui/ConfigProviderDeepLink.php - About 35 mins to fix

                          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  ConfigBoleto $config,
        CartInterface $cart,
        CcConfig $ccConfig,
        Escaper $escaper,
        Source $assetSource
                          Severity: Minor
                          Found in Model/Ui/ConfigProviderBoleto.php - About 35 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language