Sign upLogin

elisei/pagbank-payment-magento

View on GitHub
Star

Showing 159 of 159 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        ConfigPix $config,
        CartInterface $cart,
        CcConfig $ccConfig,
        Escaper $escaper,
        Source $assetSource
Severity: Minor
Found in Model/Ui/ConfigProviderPix.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            StoreManagerInterface $storeManager,
        ConfigBase $configBase,
        ClientFactory $httpClientFactory,
        Json $json,
        ThreeDsSessionDataInterfaceFactory $sessionData
    Severity: Minor
    Found in Model/Api/ThreeDsSession.php - About 35 mins to fix

      Method collectLogger has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $uri,
        $headers,
        $response,
        $request = [],
        $message = null
      Severity: Minor
      Found in Gateway/Http/Client/ApiClient.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Json $json,
        ObjectManagerInterface $objectManager,
        OrderPaymentExtensionInterfaceFactory $payExtensionFactory,
        ConfigCc $configCc,
        PaymentTokenFactoryInterface $paymentTokenFactory = null
        Severity: Minor
        Found in Gateway/Response/VaultDetailsHandler.php - About 35 mins to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  Logger $logger,
        Config $config,
        NotifierInterface $notifierInterface,
        Update $update,
        CollectionFactory $collectionFactory
          Severity: Minor
          Found in Cron/GetStatusUpdate.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    State $state,
        SearchCriteriaBuilder $searchCriteria,
        OrderRepositoryInterface $orderRepository,
        DateTime $date,
        TimezoneInterface $localeDate
            Severity: Minor
            Found in Model/Console/Command/Orders/Update.php - About 35 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          self.creditCardInstallment.subscribe((value) => {
                self.addInterest();
                creditCardData.creditCardInstallment = value;
            });
              Severity: Minor
              Found in view/frontend/web/js/view/payment/cc-form.js and 1 other location - About 35 mins to fix
              view/frontend/web/js/view/payment/method-renderer/vault.js on lines 93..96

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          self.creditCardInstallment.subscribe((value) => {
                self.addInterest();
                creditCardData.creditCardInstallment = value;
            });
              Severity: Minor
              Found in view/frontend/web/js/view/payment/method-renderer/vault.js and 1 other location - About 35 mins to fix
              view/frontend/web/js/view/payment/cc-form.js on lines 106..109

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function getUrlToConnect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getUrlToConnect()
    {
        $storeId = $this->getStore(false)->getId();
        $urlConnect = Config::ENDPOINT_CONNECT_PRODUCTION;
        $appId = Config::APP_ID_PRODUCTION;
              Severity: Minor
              Found in Block/Adminhtml/System/Config/Oauth.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getPubHeader has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getPubHeader($storeId = null)
    {
        $environment = $this->getAddtionalValue('environment', $storeId);
        $pub = $this->getAddtionalValue('cipher_text_production', $storeId);
        $app = $this->getTypeApp($storeId);
              Severity: Minor
              Found in Gateway/Config/Config.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getPurchaseItems has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getPurchaseItems(
        $order
    ) {
        $result = [];
        $items = $order->getItems();
              Severity: Minor
              Found in Gateway/Request/ItemsDataRequest.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getIcons has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getIcons()
    {
        if (!empty($this->icons)) {
            return $this->icons;
        }
              Severity: Minor
              Found in Model/Ui/ConfigProviderCc.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                              return false;
              Severity: Minor
              Found in view/base/web/js/validation/custom-validation.js - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return $this->createResult(
                200,
                [
                    'error'   => 200,
                    'message' => __('Not apply.'),
                Severity: Minor
                Found in Controller/Notification/All.php - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return resultWrapper(cardType, valid, valid);
                  Severity: Major
                  Found in view/base/web/js/model/credit-card-validation/credit-card-number-validator.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return true;
                    Severity: Major
                    Found in view/base/web/js/validation/custom-validation.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return true;
                      Severity: Major
                      Found in view/base/web/js/validation/custom-validation.js - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return $result;
                        Severity: Minor
                        Found in Controller/AbstractNotification.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return $proceed($buttonId, $data, $level, $sortOrder, $region);
                          Severity: Minor
                          Found in Plugin/SalesOrderViewButtonPlugin.php - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return false;
                            Severity: Minor
                            Found in view/base/web/js/validation/custom-validation.js - About 30 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language