Sign upLogin

elisei/pagbank-payment-magento

View on GitHub
Star

Showing 159 of 159 total issues

Function getAvailableInstallments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getAvailableInstallments($list, $storeId)
    {
        $minInstallment = $this->configCc->getMinValuelInstallment($storeId) * 100;

        foreach ($list as $key => $allInstallments) {
Severity: Minor
Found in Model/Api/ConsultPSInstallments.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function aroundAddButton has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function aroundAddButton(
        View $subject,
        \Closure $proceed,
        string $buttonId,
        array $data,
Severity: Minor
Found in Plugin/SalesOrderViewButtonPlugin.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processErrors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function processErrors(ResultInterface $result)
    {
        $messages = [];
        $errorsSource = array_merge($result->getErrorCodes(), $result->getFailsDescription());
        foreach ($errorsSource as $errorCodeOrMessage) {
Severity: Minor
Found in Gateway/Command/PaymentCommand.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Returning type \PagBank\PaymentMagento\Block\Sales\Order\Totals\PagbankInterest but initTotals() is declared to return void
Open

            return $this;
Severity: Minor
Found in Block/Sales/Order/Totals/PagbankInterest.php by phan

Possibly zero references to use statement for classlike/namespace PaymentDataObject (\Magento\Payment\Gateway\Data\PaymentDataObject)
Open

use Magento\Payment\Gateway\Data\PaymentDataObject;
Severity: Minor
Found in Gateway/Request/ReferenceIdRequest.php by phan

Possibly zero references to use statement for classlike/namespace LaminasClient (\Magento\Framework\HTTP\LaminasClient)
Open

use Magento\Framework\HTTP\LaminasClient;
Severity: Minor
Found in Model/Api/Credential.php by phan

Saw an @param annotation for storeId, but the param list of function getInstruction() : \PagBank\PaymentMagento\Block\Sales\Form\Phrase is empty
Open

     * @param int|null $storeId
Severity: Info
Found in Block/Sales/Form/DeepLink.php by phan

Possibly zero references to use statement for classlike/namespace PaymentDataObject (\Magento\Payment\Gateway\Data\PaymentDataObject)
Open

use Magento\Payment\Gateway\Data\PaymentDataObject;
Severity: Minor
Found in Gateway/Request/Boleto/HolderDataRequest.php by phan

Argument 3 (amount) is float but \PagBank\PaymentMagento\Model\Api\ConsultPSInstallments::getPagBankInstallments() takes string defined at /code/Model/Api/ConsultPSInstallments.php:79
Open

                $amount
Severity: Minor
Found in Model/Api/InterestManagement.php by phan

Saw an @param annotation for storeId, but the param list of function getInstruction() : \PagBank\PaymentMagento\Block\Sales\Form\Phrase is empty
Open

     * @param int|null $storeId
Severity: Info
Found in Block/Sales/Form/Pix.php by phan

Possibly zero references to use statement for classlike/namespace PaymentDataObject (\Magento\Payment\Gateway\Data\PaymentDataObject)
Open

use Magento\Payment\Gateway\Data\PaymentDataObject;
Severity: Minor
Found in Gateway/Request/Boleto/PaymentMethodDataRequest.php by phan

Possibly zero references to use statement for classlike/namespace InfoInterface (\Magento\Payment\Model\InfoInterface)
Open

use Magento\Payment\Model\InfoInterface;
Severity: Minor
Found in Gateway/Request/CaptureTransactionIdRequest.php by phan

Possibly zero references to use statement for classlike/namespace PaymentDataObject (\Magento\Payment\Gateway\Data\PaymentDataObject)
Open

use Magento\Payment\Gateway\Data\PaymentDataObject;
Severity: Minor
Found in Gateway/Request/DeepLink/QrCodeDataRequest.php by phan

Possibly zero references to use statement for classlike/namespace LocalizedException (\Magento\Framework\Exception\LocalizedException)
Open

use Magento\Framework\Exception\LocalizedException;
Severity: Minor
Found in Gateway/Response/FetchPaymentHandler.php by phan

Doc-block of $paymentTokenFactory in __construct is phpdoc param type \Magento\Vault\Api\Data\PaymentTokenFactoryInterface which is not a permitted replacement of the nullable param type ?\Magento\Vault\Api\Data\PaymentTokenFactoryInterface declared in the signature ('?T' should be documented as 'T|null' or '?T')
Open

     * @param PaymentTokenFactoryInterface          $paymentTokenFactory
Severity: Minor
Found in Gateway/Response/VaultDetailsHandler.php by phan

Possibly zero references to use statement for classlike/namespace InfoInterface (\Magento\Payment\Model\InfoInterface)
Open

use Magento\Payment\Model\InfoInterface;
Severity: Minor
Found in Gateway/Request/AuthTransactionIdRequest.php by phan

Possibly zero references to use statement for classlike/namespace InfoInterface (\Magento\Payment\Model\InfoInterface)
Open

use Magento\Payment\Model\InfoInterface;
Severity: Minor
Found in Gateway/Request/BillingAddressDataRequest.php by phan

Possibly zero references to use statement for classlike/namespace InfoInterface (\Magento\Payment\Model\InfoInterface)
Open

use Magento\Payment\Model\InfoInterface;
Severity: Minor
Found in Gateway/Request/OrderedTransactionIdRequest.php by phan

Possibly zero references to use statement for classlike/namespace Status (\Magento\Sales\Model\Order\Status)
Open

use Magento\Sales\Model\Order\Status;
Severity: Minor
Found in Model/Adminhtml/Source/OrderStatus.php by phan

Declaration of function generatePagBankInterest(string $cartId, \PagBank\PaymentMagento\Api\Data\CreditCardBinInterface $creditCardBin, \PagBank\PaymentMagento\Api\Data\InstallmentSelectedInterface $installmentSelected) : array should be compatible with function generatePagBankInterest(string $cartId, \PagBank\PaymentMagento\Api\Data\CreditCardBinInterface $creditCardBin, \PagBank\PaymentMagento\Api\Data\InstallmentSelectedInterface $installmentSelected) : \Magento\Quote\Api\Data\TotalsInterface defined in /code/Api/GuestInterestManagementInterface.php:31
Open

    public function generatePagBankInterest(
Severity: Minor
Found in Model/Api/GuestInterestManagement.php by phan
Severity
Category
Status
Source
Language