Sign upLogin

elliotchance/gedcom

View on GitHub
Star
cmd/gedcom/diff.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function runDiffCommand has 203 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func runDiffCommand() {
    var optionLeftGedcomFile string
    var optionRightGedcomFile string
    var optionOutputFile string
    var optionShow string // see optionShow constants.
Severity: Major
Found in cmd/gedcom/diff.go - About 7 hrs to fix

    Function runDiffCommand has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func runDiffCommand() {
    var optionLeftGedcomFile string
    var optionRightGedcomFile string
    var optionOutputFile string
    var optionShow string // see optionShow constants.
    Severity: Minor
    Found in cmd/gedcom/diff.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    // "gedcom diff" is a tool for comparing GEDCOM files and producing a HTML
    Severity: Minor
    Found in cmd/gedcom/diff.go by gofmt

    There are no issues that match your filters.

    Category
    Status