ember-cli/ember-cli

View on GitHub

Showing 269 of 269 total issues

Function _generateTestPortNumber has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  async _generateTestPortNumber(options, ui) {
    if (options.testPort === defaultPort && !options.port) {
      let foundPort = await getPort({ port: options.testPort });

      if (options.testPort !== foundPort) {
Severity: Minor
Found in lib/commands/test.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  run(commandOptions, rawArgs) {
    let blueprintName = rawArgs[0];
    let entityName = rawArgs[1];

    if (!blueprintName) {
Severity: Minor
Found in lib/commands/destroy.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('upower', ['--enumerate']);
    const devices = stdout.split('\n').filter(Boolean);

    return devices.some((device) => {
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('sysctl', ['vm.swapusage']);
    const match = /\bused = (\d+\.\d+)M\b/.exec(stdout);

    if (!match) {
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('pmset', ['-g', 'batt']);

    return stdout.indexOf('Battery Power') !== -1;
  } catch (ex) {
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('free', ['-b']);
    const lines = stdout.split('\n').filter(Boolean);
    const header = lines.shift();
    const columns = header.split(/\s+/).filter(Boolean);
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('wmic', [
      '/namespace:',
      '\\\\root\\WMI',
      'path',
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('acpi', ['--ac-adapter']);
    const lines = stdout.split('\n').filter(Boolean);

    return lines.every((line) => /off-line/.test(line));
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const value = fs.readFileSync('/sys/class/power_supply/AC/online');

    return parseInt(value, 10) === 0;
  } catch (ex) {
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('apm', ['-a']);

    return parseInt(stdout, 10) === 0;
  } catch (ex) {
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('pstat', ['-s']);
    const devices = stdout.split('\n').filter(Boolean);
    const header = devices.shift();
    const match = /^Device\s+(\d+)(K?)-blocks\s+Used\b/.exec(header);
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 176..210
lib/models/hardware-info.js on lines 214..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

  try {
    const { stdout } = execa.sync('wmic', ['PAGEFILE', 'get', 'CurrentUsage', '/format:list']);
    const match = /\bCurrentUsage=(\d+)/.exec(stdout);

    if (!match) {
Severity: Major
Found in lib/models/hardware-info.js and 9 other locations - About 35 mins to fix
lib/models/hardware-info.js on lines 9..19
lib/models/hardware-info.js on lines 23..32
lib/models/hardware-info.js on lines 46..55
lib/models/hardware-info.js on lines 75..84
lib/models/hardware-info.js on lines 88..102
lib/models/hardware-info.js on lines 106..123
lib/models/hardware-info.js on lines 127..142
lib/models/hardware-info.js on lines 146..172
lib/models/hardware-info.js on lines 176..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return 'app';
Severity: Major
Found in lib/models/blueprint.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

      return Reflect.get(targetCacheEntry, property);
Severity: Major
Found in lib/models/per-bundle-addon-cache/addon-proxy.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return experimentValue !== undefined && experimentValue !== 'false';
Severity: Major
Found in lib/experiments/index.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

          return function _originalAddonPropMethodWrapper() {
            let originalReturnValue = targetCacheEntry[TARGET_INSTANCE][property](...arguments);

            if (property === 'cacheKeyForTree') {
              const treeType = arguments[0];
Severity: Major
Found in lib/models/per-bundle-addon-cache/addon-proxy.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return result;
Severity: Major
Found in lib/tasks/npm-task.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return this.checkNpmVersion();
Severity: Major
Found in lib/tasks/npm-task.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in lib/tasks/server/middleware/history-support/index.js - About 30 mins to fix

Avoid too many return statements within this function.
Open

      return addonInstance;
Severity: Major
Found in lib/models/per-bundle-addon-cache/index.js - About 30 mins to fix
Severity
Category
Status
Source
Language