Sign upLogin

envylabs/vaulted_billing

View on GitHub
Star
lib/vaulted_billing/gateways/authorize_net_cim.rb

Summary

Maintainability
C
1 day
Test Coverage

Class AuthorizeNetCim has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

    class AuthorizeNetCim
      include VaultedBilling::Gateway
      attr_accessor :use_test_uri

      def initialize(options = {})
Severity: Minor
Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 2 hrs to fix

    File authorize_net_cim.rb has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'builder'
require 'multi_xml'

module VaultedBilling
  module Gateways
    Severity: Minor
    Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 2 hrs to fix

      Method billing_info! has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

            def billing_info!(xml, customer, credit_card)
        xml.billTo do
          xml.firstName credit_card.first_name if credit_card.first_name.present?
          xml.lastName credit_card.last_name if credit_card.last_name.present?
          xml.address credit_card.street_address if credit_card.street_address.present?
      Severity: Minor
      Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method refund has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def refund(transaction_id, amount, options = {})
        data = build_request('createCustomerProfileTransactionRequest') { |xml|
          xml.transaction do
            xml.profileTransRefund do
              xml.amount amount
      Severity: Minor
      Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method credit_card_info! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def credit_card_info!(xml, customer, credit_card)
        xml.payment do
          xml.creditCard do
            xml.cardNumber credit_card.card_number if credit_card.card_number.present?
            xml.expirationDate credit_card.expires_on.strftime("%Y-%m") if credit_card.expires_on.present?
      Severity: Minor
      Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_customer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def add_customer(customer)
        customer = customer.to_vaulted_billing
        data = build_request('createCustomerProfileRequest') do |xml|
          xml.tag!('profile') do
            xml.merchantCustomerId customer.merchant_id if customer.merchant_id
      Severity: Minor
      Found in lib/vaulted_billing/gateways/authorize_net_cim.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def authorize(customer, credit_card, amount, options = {})
        customer = customer.to_vaulted_billing
        credit_card = credit_card.to_vaulted_billing
        data = build_request('createCustomerProfileTransactionRequest') { |xml|
          xml.transaction do
      Severity: Major
      Found in lib/vaulted_billing/gateways/authorize_net_cim.rb and 1 other location - About 1 hr to fix
      lib/vaulted_billing/gateways/authorize_net_cim.rb on lines 106..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def purchase(customer, credit_card, amount, options = {})
        customer = customer.to_vaulted_billing
        credit_card = credit_card.to_vaulted_billing
        data = build_request('createCustomerProfileTransactionRequest') { |xml|
          xml.transaction do
      Severity: Major
      Found in lib/vaulted_billing/gateways/authorize_net_cim.rb and 1 other location - About 1 hr to fix
      lib/vaulted_billing/gateways/authorize_net_cim.rb on lines 124..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status