Sign upLogin

envylabs/vaulted_billing

View on GitHub
Star
lib/vaulted_billing/gateways/ipcommerce.rb

Summary

Maintainability
D
1 day
Test Coverage

File ipcommerce.rb has 385 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'multi_json'
require 'multi_xml'
require 'net/http'

module VaultedBilling
Severity: Minor
Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 5 hrs to fix

    Class Ipcommerce has 28 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Ipcommerce
      include VaultedBilling::Gateway
      
      AvsResults = [
        "Not Set", "Not Included", "Match", "No Match", "Issuer Not Certified",
    Severity: Minor
    Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 3 hrs to fix

      Method card_data has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

            def card_data(credit_card)
        return nil if credit_card.nil?
        { 
          'PaymentAccountDataToken' => credit_card.vault_id,
          'CardData' => {
      Severity: Minor
      Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method authorize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def authorize(customer, credit_card, amount, options = {})
        credit_card = credit_card.to_vaulted_billing
        data = {
          "__type" => "AuthorizeTransaction:http://schemas.ipcommerce.com/CWS/v2.0/Transactions/Rest",
          :ApplicationProfileId => @application_id,
      Severity: Minor
      Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 1 hr to fix

        Method purchase has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def purchase(customer, credit_card, amount, options = {})
        credit_card = credit_card.try(:to_vaulted_billing)
        data = {
          "__type" => "AuthorizeAndCaptureTransaction:http://schemas.ipcommerce.com/CWS/v2.0/Transactions/Rest",
          :ApplicationProfileId => @application_id,
        Severity: Minor
        Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 1 hr to fix

          Method new_transaction_from_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                def new_transaction_from_response(response)
        if response.success?
          Transaction.new({
            :id => response.body['TransactionId'],
            :avs_response => parse_avs_result(response.body['AVSResult']),
          Severity: Minor
          Found in lib/vaulted_billing/gateways/ipcommerce.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status