erikroyall/hilo

View on GitHub

Showing 292 of 292 total issues

Avoid deeply nested control flow statements.
Open

                if (contains(parts[_i])) {
                  el.classList.remove(parts[_i]);
                }
Severity: Major
Found in build/hilo-legacy.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                      if (!(unmatched[i] || setMatched[i])) {
                        setMatched[i] = pop.call(results);
                      }
    Severity: Major
    Found in build/hilo-legacy.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if (contains(parts[_i])) {
                        el.className.replace(parts[_i], "");
                      } else {
                        el.className += " " +  parts[_i];
                      }
      Severity: Major
      Found in build/hilo-legacy.js - About 45 mins to fix

        Consider simplifying this complex logical expression.
        Open

              if (support.matchesSelector && documentIsHTML &&
                (!rbuggyMatches || !rbuggyMatches.test(expr)) &&
                (!rbuggyQSA     || !rbuggyQSA.test(expr))) {
        
                try {
        Severity: Major
        Found in src/sizzle.js - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

                    if (matcher[expando]) {
                      // Find the next relative operator (if any) for proper handling
                      j = ++i;
                      for (; j < len; j++) {
                        if (Expr.relative[tokens[j].type]) {
          Severity: Major
          Found in src/sizzle.js - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                  if (support.matchesSelector && documentIsHTML &&
                    (!rbuggyMatches || !rbuggyMatches.test(expr)) &&
                    (!rbuggyQSA     || !rbuggyQSA.test(expr))) {
            
                    try {
            Severity: Major
            Found in build/hilo-legacy.js - About 40 mins to fix

              Consider simplifying this complex logical expression.
              Open

                        if (matcher[expando]) {
                          // Find the next relative operator (if any) for proper handling
                          j = ++i;
                          for (; j < len; j++) {
                            if (Expr.relative[tokens[j].type]) {
              Severity: Major
              Found in build/hilo-legacy.js - About 40 mins to fix

                Function Animation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  function Animation (el, css, timing, onanimationstart, onanimationend) {
                Severity: Minor
                Found in src/anim.js - About 35 mins to fix

                  Function CHILD has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          "CHILD": function(type, what, argument, first, last) {
                  Severity: Minor
                  Found in build/hilo-legacy.js - About 35 mins to fix

                    Function condense has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        function condense(unmatched, map, filter, context, xml) {
                    Severity: Minor
                    Found in build/hilo-legacy.js - About 35 mins to fix

                      Function animateCss has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        function animateCss (el, prop, timing, from, to) {
                      Severity: Minor
                      Found in src/anim.js - About 35 mins to fix

                        Function CHILD has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                "CHILD": function(type, what, argument, first, last) {
                        Severity: Minor
                        Found in src/sizzle.js - About 35 mins to fix

                          Function condense has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              function condense(unmatched, map, filter, context, xml) {
                          Severity: Minor
                          Found in src/sizzle.js - About 35 mins to fix

                            Function superMatcher has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    superMatcher = function(seed, context, xml, results, expandContext) {
                            Severity: Minor
                            Found in src/sizzle.js - About 35 mins to fix

                              Function superMatcher has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      superMatcher = function(seed, context, xml, results, expandContext) {
                              Severity: Minor
                              Found in build/hilo-legacy.js - About 35 mins to fix

                                Identical blocks of code found in 3 locations. Consider refactoring.
                                Open

                                  var contains = function contains (haystack, needle) {
                                    var position = arguments[1];
                                
                                    return haystack.indexOf(needle, position) !== -1;
                                  };
                                Severity: Minor
                                Found in src/util.js and 2 other locations - About 35 mins to fix
                                build/hilo-legacy.js on lines 3299..3303
                                build/hilo.js on lines 1278..1282

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 47.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 3 locations. Consider refactoring.
                                Open

                                  var contains = function contains (haystack, needle) {
                                    var position = arguments[1];
                                
                                    return haystack.indexOf(needle, position) !== -1;
                                  };
                                Severity: Minor
                                Found in build/hilo-legacy.js and 2 other locations - About 35 mins to fix
                                build/hilo.js on lines 1278..1282
                                src/util.js on lines 206..210

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 47.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 3 locations. Consider refactoring.
                                Open

                                  var contains = function contains (haystack, needle) {
                                    var position = arguments[1];
                                
                                    return haystack.indexOf(needle, position) !== -1;
                                  };
                                Severity: Minor
                                Found in build/hilo.js and 2 other locations - About 35 mins to fix
                                build/hilo-legacy.js on lines 3299..3303
                                src/util.js on lines 206..210

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 47.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Function toPrimitive has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  var toPrimitive = function toPrimitive (input) {
                                    var val, valueOf, toString;
                                
                                    if (isPrimitive(input)) {
                                      return input;
                                Severity: Minor
                                Found in src/util.js - About 35 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function ifContains has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    ifContains: function (tw) {
                                      var ifString = this.con.split(tw).length === 1 ? false : true;
                                      if (typeof tw === "string" && typeof this.con === "object" && this.con.length) {
                                
                                      } else if (typeof tw === "string" && typeof this.con === "string") {
                                Severity: Minor
                                Found in src/test.js - About 35 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language