Sign upLogin

erikroyall/hilo

View on GitHub
Star

Showing 292 of 292 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  function Test (con, neg) {
    this.con = con;
    
    if (neg) {
      this.neg = true;
Severity: Minor
Found in build/hilo.js and 2 other locations - About 30 mins to fix
build/hilo-legacy.js on lines 3479..3485
src/test.js on lines 49..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return new Dom(input);
Severity: Major
Found in build/hilo-legacy.js - About 30 mins to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

      function Test (con, neg) {
    this.con = con;
    
    if (neg) {
      this.neg = true;
    Severity: Minor
    Found in build/hilo-legacy.js and 2 other locations - About 30 mins to fix
    build/hilo.js on lines 1449..1455
    src/test.js on lines 49..55

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

                    return results;
    Severity: Major
    Found in build/hilo-legacy.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return select(selector.replace(rtrim, "$1"), context, results, seed);
      Severity: Major
      Found in build/hilo-legacy.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return results;
        Severity: Major
        Found in build/hilo-legacy.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return a.compareDocumentPosition ? -1 : 1;
          Severity: Major
          Found in build/hilo-legacy.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return win.Hilo;
            Severity: Major
            Found in build/hilo-legacy.js - About 30 mins to fix

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                function Test (con, neg) {
    this.con = con;
    
    if (neg) {
      this.neg = true;
              Severity: Minor
              Found in src/test.js and 2 other locations - About 30 mins to fix
              build/hilo-legacy.js on lines 3479..3485
              build/hilo.js on lines 1449..1455

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  filter: function (fn) {
      var len = this.length >>> 0
        , _i
        , t = Object(this)
        , res = []
              Severity: Minor
              Found in src/dom.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function forIn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                var forIn = function forIn (obj, fn, thisRef) {
    var _i;

    // Throw an error if object and function are not provided
    if (!(obj && fn)) {
              Severity: Minor
              Found in src/util.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function toggle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  toggle: function (display) {
      return this.each(function (el) {
        if (el.style.display === "none") {
          el.style.display = display ? display : "";
          // ARIA
              Severity: Minor
              Found in src/fx.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language