Sign upLogin

ernestwisniewski/kbin

View on GitHub
Star

Showing 464 of 573 total issues

Method getUserReputation has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getUserReputation(User $user, string $className, int $page = 1): PagerfantaInterface
    {
        $conn = $this->getEntityManager()
            ->getConnection();
Severity: Minor
Found in src/Repository/ReputationRepository.php - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
    {
        $user = $token->getUser();

        if (!$user instanceof User) {
    Severity: Major
    Found in src/Security/Voter/MessageThreadVoter.php and 2 other locations - About 1 hr to fix
    src/Security/Voter/NotificationVoter.php on lines 31..48
    src/Security/Voter/OAuth2UserConsentVoter.php on lines 31..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
    {
        $user = $token->getUser();

        if (!$user instanceof User) {
    Severity: Major
    Found in src/Security/Voter/OAuth2UserConsentVoter.php and 2 other locations - About 1 hr to fix
    src/Security/Voter/MessageThreadVoter.php on lines 31..48
    src/Security/Voter/NotificationVoter.php on lines 31..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
    {
        $user = $token->getUser();

        if (!$user instanceof User) {
    Severity: Major
    Found in src/Security/Voter/NotificationVoter.php and 2 other locations - About 1 hr to fix
    src/Security/Voter/MessageThreadVoter.php on lines 31..48
    src/Security/Voter/OAuth2UserConsentVoter.php on lines 31..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function filter has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function filter(QueryBuilder $qb, Criteria $criteria): void
    {
        if ($criteria->post) {
            $qb->andWhere('c.post = :post')
                ->setParameter('post', $criteria->post);
    Severity: Minor
    Found in src/Repository/PostCommentRepository.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function consent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function consent(Request $request, EntityManagerInterface $entityManager): Response
    {
        $clientId = $request->query->get('client_id');
        if (!$clientId || !ctype_alnum($clientId) || !$this->getUser()) {
            return $this->redirectToRoute('front');
    Severity: Minor
    Found in src/Controller/Security/LoginController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getDailyStats has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getDailyStats(string $table, string $relation = null): array
    {
        $conn = $this->getEntityManager()
            ->getConnection();
    Severity: Minor
    Found in src/Repository/StatsVotesRepository.php - About 1 hr to fix

      Method findPaginated has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function findPaginated(MagazinePageView $criteria): PagerfantaInterface
    {
        $qb = $this->createQueryBuilder('m')
            ->andWhere('m.visibility = :visibility')
            ->setParameter('visibility', VisibilityInterface::VISIBILITY_VISIBLE);
      Severity: Minor
      Found in src/Repository/MagazineRepository.php - About 1 hr to fix

        Method views has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            #[OA\Response(
        response: 200,
        description: 'Views by interval retrieved. These are not guaranteed to be continuous.',
        content: new OA\JsonContent(
            properties: [
        Severity: Minor
        Found in src/Controller/Api/Magazine/Admin/MagazineRetrieveStatsApi.php - About 1 hr to fix

          Method __construct has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __construct(
        string $email,
        string $username,
        string $password,
        string $apProfileId = null,
          Severity: Minor
          Found in src/Entity/User.php - About 1 hr to fix

            Method views has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                #[OA\Response(
        response: 200,
        description: 'Views by interval retrieved. These are not guaranteed to be continuous.',
        content: new OA\JsonContent(
            properties: [
            Severity: Minor
            Found in src/Controller/Api/Instance/InstanceRetrieveStatsApi.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (data.detail.op.endsWith('CommentCreatedNotification') && this.hasCommentsCounterTarget) {
            this.commentsCounterTarget.innerText = parseInt(this.commentsCounterTarget.innerText) + 1;
        }
              Severity: Major
              Found in assets/controllers/subject_controller.js and 1 other location - About 1 hr to fix
              assets/controllers/subject_controller.js on lines 329..331

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (data.detail.op.endsWith('CommentDeletedNotification') && this.hasCommentsCounterTarget) {
            this.commentsCounterTarget.innerText = parseInt(this.commentsCounterTarget.innerText) - 1;
        }
              Severity: Major
              Found in assets/controllers/subject_controller.js and 1 other location - About 1 hr to fix
              assets/controllers/subject_controller.js on lines 325..327

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  #[IsGranted('ROLE_USER')]
    #[IsGranted('follow', subject: 'following')]
    public function follow(User $following, Request $request): Response
    {
        $this->validateCsrf('follow', $request->request->get('token'));
              Severity: Major
              Found in src/Controller/User/UserFollowController.php and 1 other location - About 1 hr to fix
              src/Controller/User/UserFollowController.php on lines 41..54

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  #[IsGranted('ROLE_USER')]
    #[IsGranted('follow', subject: 'following')]
    public function unfollow(User $following, Request $request): Response
    {
        $this->validateCsrf('follow', $request->request->get('token'));
              Severity: Major
              Found in src/Controller/User/UserFollowController.php and 1 other location - About 1 hr to fix
              src/Controller/User/UserFollowController.php on lines 26..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 107.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function show has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  async show(event) {
        event.preventDefault();

        let container = this.element.nextElementSibling && this.element.nextElementSibling.classList.contains('js-container')
            ? this.element.nextElementSibling : null;
              Severity: Minor
              Found in assets/controllers/preview_controller.js - About 1 hr to fix

                Method preparePageResults has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function preparePageResults(iterable $posts): ?iterable
    {
        $firstIndexes = [];
        $tmp = [];
        $duplicates = [];
                Severity: Minor
                Found in src/Kbin/Entry/EntryCrosspost.php - About 1 hr to fix

                  Method fetch has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function fetch($url): self
    {
        if ($this->settings->isLocalUrl($url)) {
            return $this;
        }
                  Severity: Minor
                  Found in src/Utils/Embed.php - About 1 hr to fix

                    Method fetch has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function fetch($url): self
    {
        if ($this->settings->isLocalUrl($url)) {
            return $this;
        }
                    Severity: Minor
                    Found in src/Kbin/Utils/Embed.php - About 1 hr to fix

                      Method content has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          #[OA\Response(
        response: 200,
        description: 'Submissions by interval retrieved. These are not guaranteed to be continuous.',
        content: new OA\JsonContent(
            properties: [
                      Severity: Minor
                      Found in src/Controller/Api/Magazine/Admin/MagazineRetrieveStatsApi.php - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language