Sign upLogin

ernestwisniewski/kbin

View on GitHub
Star

Showing 464 of 573 total issues

Method updateUser has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function updateUser(string $actorUrl): User
    {
        $user = $this->userRepository->findOneBy(['apProfileId' => $actorUrl]);

        $actor = $this->apHttpClient->getActorObject($actorUrl);
Severity: Minor
Found in src/Service/ActivityPubManager.php - About 1 hr to fix

    Method votes has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        #[OA\Response(
        response: 200,
        description: 'Votes by interval retrieved. These are not guaranteed to be continuous.',
        content: new OA\JsonContent(
            properties: [
    Severity: Minor
    Found in src/Controller/Api/Magazine/Admin/MagazineRetrieveStatsApi.php - About 1 hr to fix

      Method votes has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          #[OA\Response(
        response: 200,
        description: 'Votes by interval retrieved. These are not guaranteed to be continuous.',
        content: new OA\JsonContent(
            properties: [
      Severity: Minor
      Found in src/Controller/Api/Instance/InstanceRetrieveStatsApi.php - About 1 hr to fix

        Method content has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            #[OA\Response(
        response: 200,
        description: 'Submissions by interval retrieved. These are not guaranteed to be continuous.',
        content: new OA\JsonContent(
            properties: [
        Severity: Minor
        Found in src/Controller/Api/Instance/InstanceRetrieveStatsApi.php - About 1 hr to fix

          Method buildForm has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add('currentPassword', PasswordType::class, [
                    'label' => 'current_password',
          Severity: Minor
          Found in src/Kbin/User/Form/UserPasswordType.php - About 1 hr to fix

            Method __invoke has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                #[OA\Response(
        response: 200,
        description: 'Accesses by interval retrieved. These are not guaranteed to be continuous.',
        content: new OA\JsonContent(
            properties: [
            Severity: Minor
            Found in src/Controller/Api/OAuth2/Admin/RetrieveClientStatsApi.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function unblockDomain(Domain $domain): void
    {
        $criteria = Criteria::create()
            ->where(Criteria::expr()->eq('domain', $domain));
              Severity: Major
              Found in src/Entity/User.php and 1 other location - About 1 hr to fix
              src/Entity/User.php on lines 584..600

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  #[OA\Response(
        response: 200,
        description: 'Returns the site\'s details',
        content: new OA\JsonContent(ref: new Model(type: SiteResponseDto::class)),
        headers: [
              Severity: Major
              Found in src/Controller/Api/Instance/InstanceDetailsApi.php and 1 other location - About 1 hr to fix
              src/Controller/Api/Entry/EntriesUpdateApi.php on lines 69..90

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function unblockMagazine(Magazine $magazine): void
    {
        $criteria = Criteria::create()
            ->where(Criteria::expr()->eq('magazine', $magazine));
              Severity: Major
              Found in src/Entity/User.php and 1 other location - About 1 hr to fix
              src/Entity/User.php on lines 619..635

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  #[OA\Response(
        response: 429,
        description: 'You are being rate limited',
        content: new OA\JsonContent(ref: new Model(type: TooManyRequestsErrorSchema::class)),
        headers: [
              Severity: Major
              Found in src/Controller/Api/Entry/EntriesUpdateApi.php and 1 other location - About 1 hr to fix
              src/Controller/Api/Instance/InstanceDetailsApi.php on lines 20..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method create has 10 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static function create(string $identifier, string $secret, string $name, UserSmallResponseDto $user = null, string $contactEmail = null, string $description = null, array $redirectUris = [], array $grants = [], array $scopes = ['read'], ImageDto $image = null): OAuth2ClientDto
              Severity: Major
              Found in src/DTO/OAuth2ClientDto.php - About 1 hr to fix

                Function getForm has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    async getForm(event) {
        event.preventDefault();

        if ('' !== this.containerTarget.innerHTML.trim()) {
            if (false === confirm('Do you really want to leave?')) {
                Severity: Minor
                Found in assets/controllers/subject_controller.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function setLinks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function setLinks(array $links)
    {
        foreach ($links as $link) {
            if (!\is_array($link)) {
                throw new \Exception('WebFinger links must be an array of objects');
                Severity: Minor
                Found in src/Service/ActivityPub/Webfinger/WebFinger.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function show has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    async show(event) {
        event.preventDefault();

        let container = this.element.nextElementSibling && this.element.nextElementSibling.classList.contains('js-container')
            ? this.element.nextElementSibling : null;
                Severity: Minor
                Found in assets/controllers/preview_controller.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method create has 10 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        int $id = null,
        MagazineSmallResponseDto $magazine = null,
        UserSmallResponseDto $reported = null,
        UserSmallResponseDto $reporting = null,
        string $reason = null,
                Severity: Major
                Found in src/Kbin/Report/DTO/ReportResponseDto.php - About 1 hr to fix

                  Method subscribed has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      #[IsGranted('ROLE_USER')]
    public function subscribed(?string $sortBy, ?string $time, PostRepository $repository, Request $request): Response
    {
        $user = $this->getUserOrThrow();
                  Severity: Minor
                  Found in src/Controller/Post/PostFrontController.php - About 1 hr to fix

                    Function handleEntries has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        async handleEntries(url) {
        let response = await fetch(url, {method: 'GET'});

        response = await ok(response);
                    Severity: Minor
                    Found in assets/controllers/infinite_scroll_controller.js - About 1 hr to fix

                      Method validate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          #[Assert\Callback]
    public function validate(
        ExecutionContextInterface $context,
        $payload
    ) {
                      Severity: Minor
                      Found in src/DTO/OAuth2ClientDto.php - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            #[IsGranted(new Expression('is_granted("ROLE_ADMIN") or is_granted("ROLE_MODERATOR")'))]
    public function ban(User $user, Request $request): Response
    {
        $this->validateCsrf('user_ban', $request->request->get('token'));
                        Severity: Major
                        Found in src/Controller/User/UserBanController.php and 1 other location - About 1 hr to fix
                        src/Controller/User/UserBanController.php on lines 45..61

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 105.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            #[IsGranted(new Expression('is_granted("ROLE_ADMIN") or is_granted("ROLE_MODERATOR")'))]
    public function unban(User $user, Request $request): Response
    {
        $this->validateCsrf('user_ban', $request->request->get('token'));
                        Severity: Major
                        Found in src/Controller/User/UserBanController.php and 1 other location - About 1 hr to fix
                        src/Controller/User/UserBanController.php on lines 27..43

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 105.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language