Sign upLogin

ernestwisniewski/kbin

View on GitHub
Star

Showing 464 of 573 total issues

Function __invoke has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function __invoke(
        #[MapEntity(mapping: ['magazine_name' => 'name'])]
        Magazine $magazine,
        #[MapEntity(id: 'entry_id')]
        Entry $entry,
Severity: Minor
Found in src/Controller/Entry/EntrySingleController.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        #[MapEntity(id: 'post_id')]
        Post $post,
        PostEdit $postEdit,
        PostFactory $postFactory,
        ValidatorInterface $validator,
Severity: Minor
Found in src/Controller/Api/Post/PostsUpdateApi.php - About 45 mins to fix

    Function __invoke has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __invoke(
        #[MapEntity(mapping: ['magazine_name' => 'name'])]
        Magazine $magazine,
        #[MapEntity(id: 'post_id')]
        Post $post,
    Severity: Minor
    Found in src/Controller/Post/PostSingleController.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            #[MapEntity(id: 'post_id')]
        Post $post,
        #[MapEntity(id: 'comment_id')]
        ?PostComment $parent,
        PostCommentCreate $postCommentCreate,
    Severity: Minor
    Found in src/Controller/Api/Post/Comments/PostCommentsCreateApi.php - About 45 mins to fix

      Method uploadImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              #[MapEntity(id: 'entry_id')]
        Entry $entry,
        #[MapEntity(id: 'comment_id')]
        ?EntryComment $parent,
        EntryCommentCreate $entryCommentCreate,
      Severity: Minor
      Found in src/Controller/Api/Entry/Comments/EntryCommentsCreateApi.php - About 45 mins to fix

        Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                #[MapEntity(id: 'user_id')]
        User $user,
        EntryRepository $repository,
        EntryFactory $factory,
        RequestStack $request,
        Severity: Minor
        Found in src/Controller/Api/Entry/UserEntriesRetrieveApi.php - About 45 mins to fix

          Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  #[MapEntity(id: 'entry_id')]
        Entry $entry,
        #[MapEntity(id: 'comment_id')]
        ?EntryComment $parent,
        EntryCommentCreate $entryCommentCreate,
          Severity: Minor
          Found in src/Controller/Api/Entry/Comments/EntryCommentsCreateApi.php - About 45 mins to fix

            Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    #[MapEntity(id: 'magazine_id')]
        Magazine $magazine,
        EntryRepository $repository,
        EntryFactory $factory,
        RequestStack $request,
            Severity: Minor
            Found in src/Controller/Api/Entry/MagazineEntriesRetrieveApi.php - About 45 mins to fix

              Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      Request $request,
        ClientManagerInterface $manager,
        EntityManagerInterface $entityManager,
        CredentialsRevokerInterface $revoker,
        ValidatorInterface $validator,
              Severity: Minor
              Found in src/Controller/Api/OAuth2/DeleteClientApi.php - About 45 mins to fix

                Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    #[Assert\Callback]
    public function validate(
        ExecutionContextInterface $context,
        $payload
    ) {
                Severity: Minor
                Found in src/Kbin/Post/DTO/PostDto.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function __invoke has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function __invoke(string $body, array $tags): string
    {
        $current = ($this->tagExtract)($body, null) ?? [];

        $join = array_unique(array_merge(array_diff($tags, $current)));
                Severity: Minor
                Found in src/Kbin/Tag/TagJoinToBody.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        #[MapEntity(id: 'user_id')]
        User $user,
        PostRepository $repository,
        PostFactory $factory,
        RequestStack $request,
                Severity: Minor
                Found in src/Controller/Api/Post/UserPostsRetrieveApi.php - About 45 mins to fix

                  Method byMagazine has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          #[MapEntity(id: 'magazine_id')]
        Magazine $magazine,
        PostRepository $repository,
        PostFactory $factory,
        RequestStack $request,
                  Severity: Minor
                  Found in src/Controller/Api/Post/PostsRetrieveApi.php - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            return fetch(path).then(() => {
            if (reloadRequired) {
                document.querySelector('.settings-list').classList.add('reload-required');
            }
        });
                    Severity: Minor
                    Found in assets/controllers/settings_row_switch_controller.js and 1 other location - About 45 mins to fix
                    assets/controllers/settings_row_enum_controller.js on lines 14..18

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            return fetch(actionPath).then(() => {
            if (reloadRequired) {
                document.querySelector('.settings-list').classList.add('reload-required');
            }
        });
                    Severity: Minor
                    Found in assets/controllers/settings_row_enum_controller.js and 1 other location - About 45 mins to fix
                    assets/controllers/settings_row_switch_controller.js on lines 17..21

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            SearchManager $manager,
        UserFactory $userFactory,
        MagazineFactory $magazineFactory,
        SettingsManager $settingsManager,
        RateLimiterFactory $apiReadLimiter,
                    Severity: Minor
                    Found in src/Controller/Api/Search/SearchRetrieveApi.php - About 45 mins to fix

                      Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          #[Assert\Callback]
    public function validate(
        ExecutionContextInterface $context,
        $payload
    ) {
                      Severity: Minor
                      Found in src/Kbin/EntryComment/DTO/EntryCommentDto.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method uploadImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              #[MapEntity(id: 'post_id')]
        Post $post,
        #[MapEntity(id: 'comment_id')]
        ?PostComment $parent,
        PostCommentCreate $postCommentCreate,
                      Severity: Minor
                      Found in src/Controller/Api/Post/Comments/PostCommentsCreateApi.php - About 45 mins to fix

                        Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            #[Assert\Callback]
    public function validate(
        ExecutionContextInterface $context,
        $payload
    ) {
                        Severity: Minor
                        Found in src/Kbin/PostComment/DTO/PostCommentDto.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                #[MapEntity(id: 'domain_id')]
        Domain $domain,
        EntryRepository $repository,
        EntryFactory $factory,
        RequestStack $request,
                        Severity: Minor
                        Found in src/Controller/Api/Entry/DomainEntriesRetrieveApi.php - About 45 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language