Sign upLogin

espressopp/espressopp

View on GitHub
Star

Showing 1,134 of 1,134 total issues

Function handshake has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def handshake(initsock):
    print("before")
    (sock, sock_port) = initsock.accept()
    print("after")
    header = struct.Struct('!II')
Severity: Minor
Found in src/tools/vmd.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generate_md has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def generate_md(use_vec=True):
    print('{}USING VECTORIZATION'.format('NOT ' if not use_vec else ''))

    if use_vec:
        Default = espressopp.vec.standard_system.Default
Severity: Minor
Found in testsuite/vec/test_vec_polymer_melt.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function test0Lattice has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def test0Lattice(self) :
        system = espressopp.System()

        rng  = espressopp.esutil.RNG()
Severity: Minor
Found in testsuite/unittest/testVerletList.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

sys.stdout.write(fmt % (steps, T, P, Pij[3], Etotal, Ek, Ep, Eb, Ea))
Severity: Minor
Found in bench/polymer_melt/espressopp/espressopp_polymer_melt_tabulated.py and 2 other locations - About 35 mins to fix
bench/polymer_melt/espressopp/espressopp_polymer_melt.py on lines 155..155
testsuite/tabulated/polymer_melt_tabulated.py on lines 234..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    for k in range(100):
        integrator.run(10000)
        espressopp.tools.analyse.info(system, integrator)
Severity: Major
Found in examples/lj_cos/lj_cos.py and 6 other locations - About 35 mins to fix
examples/fix_particles/fix_particles.py on lines 60..62
examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py on lines 195..197
examples/stillinger_weber_Si/stillinger_weber_silicon.py on lines 196..198
src/tools/warmup.py on lines 67..69
testsuite/pickle_potential/warmup/testWarmup.py on lines 68..70
testsuite/pickle_potential/warmup/testWarmup.py on lines 75..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

for k in range(20):
    steepest.run(isteps)
    espressopp.tools.analyse.info(system, steepest)
Severity: Major
Found in examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py and 5 other locations - About 35 mins to fix
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 137..139
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 147..149
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 153..155
examples/hierarchical_strategy_for_one-component/reinsertion.py on lines 328..330
examples/hierarchical_strategy_for_one-component/reinsertion.py on lines 334..336

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

sys.stdout.write(fmt % (steps, T, P, Pij[3], Etotal, Ek, Ep, Eb, Ea))
Severity: Minor
Found in bench/polymer_melt/espressopp/espressopp_polymer_melt.py and 2 other locations - About 35 mins to fix
bench/polymer_melt/espressopp/espressopp_polymer_melt_tabulated.py on lines 184..184
testsuite/tabulated/polymer_melt_tabulated.py on lines 234..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

for i in range(10000):
    integrator.run(100)
    espressopp.tools.vmd.imd_positions(system, sock)
Severity: Major
Found in examples/fix_particles/fix_particles.py and 6 other locations - About 35 mins to fix
examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py on lines 195..197
examples/lj_cos/lj_cos.py on lines 161..163
examples/stillinger_weber_Si/stillinger_weber_silicon.py on lines 196..198
src/tools/warmup.py on lines 67..69
testsuite/pickle_potential/warmup/testWarmup.py on lines 68..70
testsuite/pickle_potential/warmup/testWarmup.py on lines 75..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

for i in range (10):
    integrator.run(1000)
    espressopp.tools.analyse.info(system, integrator)
Severity: Major
Found in examples/stillinger_weber_Si/stillinger_weber_silicon.py and 6 other locations - About 35 mins to fix
examples/fix_particles/fix_particles.py on lines 60..62
examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py on lines 195..197
examples/lj_cos/lj_cos.py on lines 161..163
src/tools/warmup.py on lines 67..69
testsuite/pickle_potential/warmup/testWarmup.py on lines 68..70
testsuite/pickle_potential/warmup/testWarmup.py on lines 75..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

for k in range(30):
    steepest.run(isteps)
    espressopp.tools.analyse.info(system, steepest)
Severity: Major
Found in examples/hierarchical_strategy_for_one-component/reinsertion.py and 5 other locations - About 35 mins to fix
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 137..139
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 147..149
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 153..155
examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py on lines 190..192
examples/hierarchical_strategy_for_one-component/reinsertion.py on lines 334..336

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

for step in range(equil_nloops):
    # perform equilibration_isteps integration steps
    integrator.run(equil_isteps)
    # print status information
    espressopp.tools.analyse.info(system, integrator)
Severity: Major
Found in examples/lennard_jones_em/lennard_jones.py and 5 other locations - About 35 mins to fix
examples/lennard_jones/lennard_jones.py on lines 269..273
examples/vec/lennard_jones/lennard_jones.py on lines 325..329
testsuite/vec/test_vec_lennard_jones.py on lines 96..98
testsuite/vec/test_vec_polymer_melt.py on lines 114..116
testsuite/verlet_list_buffer/verlet_list_buffer.py on lines 72..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    sys.stdout.write(fmt % (steps, T, P, Pij[3], Etotal, Ek, Ep, Eb, Ea))
Severity: Minor
Found in testsuite/tabulated/polymer_melt_tabulated.py and 2 other locations - About 35 mins to fix
bench/polymer_melt/espressopp/espressopp_polymer_melt.py on lines 155..155
bench/polymer_melt/espressopp/espressopp_polymer_melt_tabulated.py on lines 184..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

for k in range(100):
    integrator.run(1000)
    espressopp.tools.analyse.info(system, integrator)
Severity: Major
Found in examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py and 6 other locations - About 35 mins to fix
examples/fix_particles/fix_particles.py on lines 60..62
examples/lj_cos/lj_cos.py on lines 161..163
examples/stillinger_weber_Si/stillinger_weber_silicon.py on lines 196..198
src/tools/warmup.py on lines 67..69
testsuite/pickle_potential/warmup/testWarmup.py on lines 68..70
testsuite/pickle_potential/warmup/testWarmup.py on lines 75..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

for k in range(10):
    integrator.run(100)
    espressopp.tools.analyse.info(system, integrator)
Severity: Major
Found in testsuite/pickle_potential/warmup/testWarmup.py and 6 other locations - About 35 mins to fix
examples/fix_particles/fix_particles.py on lines 60..62
examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py on lines 195..197
examples/lj_cos/lj_cos.py on lines 161..163
examples/stillinger_weber_Si/stillinger_weber_silicon.py on lines 196..198
src/tools/warmup.py on lines 67..69
testsuite/pickle_potential/warmup/testWarmup.py on lines 68..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

for k in range(20):
    steepest.run(isteps)
    espressopp.tools.analyse.info(system, steepest)
Severity: Major
Found in examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py and 5 other locations - About 35 mins to fix
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 137..139
examples/hierarchical_strategy_for_one-component/generate_microscopic-c.py on lines 153..155
examples/hierarchical_strategy_for_one-component/polymer_melt_from_restart.py on lines 190..192
examples/hierarchical_strategy_for_one-component/reinsertion.py on lines 328..330
examples/hierarchical_strategy_for_one-component/reinsertion.py on lines 334..336

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    for k in range(nsteps):
        integrator.run(isteps)
        espressopp.tools.analyse.info(system, integrator)
Severity: Major
Found in testsuite/vec/test_vec_lennard_jones.py and 5 other locations - About 35 mins to fix
examples/lennard_jones/lennard_jones.py on lines 269..273
examples/lennard_jones_em/lennard_jones.py on lines 198..202
examples/vec/lennard_jones/lennard_jones.py on lines 325..329
testsuite/vec/test_vec_polymer_melt.py on lines 114..116
testsuite/verlet_list_buffer/verlet_list_buffer.py on lines 72..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                goal.append(softblobs_chain[id + 1][0][k])
Severity: Minor
Found in examples/hierarchical_strategy_for_one-component/reinsertion.py and 1 other location - About 35 mins to fix
examples/hierarchical_strategy_for_one-component/reinsertion.py on lines 177..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        self.dump_h5md = espressopp.io.DumpH5MD(
            self.system,
            self.integrator,
            self.h5md_file,
Severity: Minor
Found in testsuite/FileIOTests/h5md/dump_topology_test.py and 1 other location - About 35 mins to fix
testsuite/FileIOTests/h5md/dump_h5md_test.py on lines 55..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        for i in range(3):
            cellGrid[i] = calcNumberCells(SIZE, nodeGrid[i], cutoff)
Severity: Minor
Found in testsuite/integrator/testVelocityVerlet.py and 1 other location - About 35 mins to fix
testsuite/unittest/testVerletList.py on lines 63..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        self.dump_h5md = espressopp.io.DumpH5MD(
            self.system,
            self.integrator,
            self.h5md_file,
Severity: Minor
Found in testsuite/FileIOTests/h5md/dump_h5md_test.py and 1 other location - About 35 mins to fix
testsuite/FileIOTests/h5md/dump_topology_test.py on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language