Sign upLogin

etehtsea/oxblood

View on GitHub
Star

Showing 130 of 130 total issues

Line is too long. [81/80]
Open

      # @option opts [Array<Integer, Integer>] :limit Get a range of the matching
Severity: Minor
Found in lib/oxblood/commands/sorted_sets.rb by rubocop

Line is too long. [83/80]
Open

      # Remove all members in a sorted set between the given lexicographical range.
Severity: Minor
Found in lib/oxblood/commands/sorted_sets.rb by rubocop

Missing top-level class documentation comment.
Open

    class Oxblood
Severity: Minor
Found in lib/redis/connection/oxblood.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use array literal [] instead of Array.new.
Open

      @commands = Array.new
Severity: Minor
Found in lib/oxblood/pipeline.rb by rubocop

This cop checks for the use of a method, the result of which would be a literal, like an empty array, hash or string.

Example:

# bad
a = Array.new
h = Hash.new
s = String.new

# good
a = []
h = {}
s = ''

Line is too long. [81/80]
Open

      # @param [[String, String], Array<[String, String]>] args fields and values
Severity: Minor
Found in lib/oxblood/commands/hashes.rb by rubocop

Line is too long. [82/80]
Open

      #   or 0 when field is not present in the hash or key does not exist at all.
Severity: Minor
Found in lib/oxblood/commands/hashes.rb by rubocop

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

          if v = opts_or_addr[:type]
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

Line is too long. [86/80]
Open

      #   `false` value acts as NOSAVE. `nil` or absence of option don't add anything.
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

Line is too long. [84/80]
Open

    # @option opts [String] :host ('localhost') Hostname or IP address to connect to
Severity: Minor
Found in lib/oxblood/connection.rb by rubocop

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if storedist_key = opts[:storedist]
Severity: Minor
Found in lib/oxblood/commands/geo.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

Literal true appeared as a condition.
Open

      end while true
Severity: Minor
Found in lib/oxblood/rsocket.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Line is too long. [82/80]
Open

      # @return [RError] if the key contains a value of the wrong type or contains
Severity: Minor
Found in lib/oxblood/commands/strings.rb by rubocop

Line is too long. [82/80]
Open

      # @return [String] without the additional count argument the command returns
Severity: Minor
Found in lib/oxblood/commands/sets.rb by rubocop

Provide an exception class and message as arguments to raise.
Open

        raise Redis::TimeoutError.new(e.message)
Severity: Minor
Found in lib/redis/connection/oxblood.rb by rubocop

This cop checks the args passed to fail and raise. For exploded style (default), it recommends passing the exception class and message to raise, rather than construct an instance of the error. It will still allow passing just a message, or the construction of an error with more than one argument.

The exploded style works identically, but with the addition that it will also suggest constructing error objects when the exception is passed multiple arguments.

Example: EnforcedStyle: exploded (default)

# bad
raise StandardError.new("message")

# good
raise StandardError, "message"
fail "message"
raise MyCustomError.new(arg1, arg2, arg3)
raise MyKwArgError.new(key1: val1, key2: val2)

Example: EnforcedStyle: compact

# bad
raise StandardError, "message"
raise RuntimeError, arg1, arg2, arg3

# good
raise StandardError.new("message")
raise MyCustomError.new(arg1, arg2, arg3)
fail "message"

required_ruby_version (2.2, declared in oxblood.gemspec) and TargetRubyVersion (2.1, declared in .rubocop.yml) should be equal.
Open

  spec.required_ruby_version = '>= 2.2.2'
Severity: Minor
Found in oxblood.gemspec by rubocop

Checks that required_ruby_version of gemspec and TargetRubyVersion of .rubocop.yml are equal. Thereby, RuboCop to perform static analysis working on the version required by gemspec.

Example:

# When `TargetRubyVersion` of .rubocop.yml is `2.3`.

# bad
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.2.0'
end

# bad
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.4.0'
end

# good
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.3.0'
end

# good
Gem::Specification.new do |spec|
  spec.required_ruby_version = '>= 2.3'
end

# good
Gem::Specification.new do |spec|
  spec.required_ruby_version = ['>= 2.3.0', '< 2.5.0']
end

Line is too long. [82/80]
Open

      # @return [RError] if the key contains a value of the wrong type or contains
Severity: Minor
Found in lib/oxblood/commands/strings.rb by rubocop

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

          if v = opts_or_addr[:id]
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

Missing top-level module documentation comment.
Open

    module HyperLogLog
Severity: Minor
Found in lib/oxblood/commands/hyper_log_log.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if v = opts[:match]
Severity: Minor
Found in lib/oxblood/commands/scan.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

Missing top-level module documentation comment.
Open

    module Sets
Severity: Minor
Found in lib/oxblood/commands/sets.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end
Severity
Category
Status
Source
Language