src/Phan/Analysis.php

Summary

Maintainability
F
4 days
Test Coverage

Function loadMethodPlugins has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

    public static function loadMethodPlugins(CodeBase $code_base): void
    {
        $plugin_set = ConfigPluginSet::instance();
        $return_type_overrides = $plugin_set->getReturnTypeOverrides($code_base);
        $return_type_override_fqsen_strings = [];
Severity: Minor
Found in src/Phan/Analysis.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Analysis.php has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Phan;
Severity: Minor
Found in src/Phan/Analysis.php - About 4 hrs to fix

    The class Analysis has an overall complexity of 70 which is very high. The configured complexity threshold is 50.
    Open

    class Analysis
    {
        /**
         * This first pass parses code and looks for the subset
         * of issues that can be found without having to have
    Severity: Minor
    Found in src/Phan/Analysis.php by phpmd

    Method loadMethodPlugins has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function loadMethodPlugins(CodeBase $code_base): void
        {
            $plugin_set = ConfigPluginSet::instance();
            $return_type_overrides = $plugin_set->getReturnTypeOverrides($code_base);
            $return_type_override_fqsen_strings = [];
    Severity: Major
    Found in src/Phan/Analysis.php - About 3 hrs to fix

      Method analyzeFunctions has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function analyzeFunctions(CodeBase $code_base, array $file_filter = null): void
          {
              $plugin_set = ConfigPluginSet::instance();
              $has_function_or_method_plugins = $plugin_set->hasAnalyzeFunctionPlugins() || $plugin_set->hasAnalyzeMethodPlugins();
              $show_progress = CLI::shouldShowProgress();
      Severity: Major
      Found in src/Phan/Analysis.php - About 2 hrs to fix

        Method parseFile has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function parseFile(CodeBase $code_base, string $file_path, bool $suppress_parse_errors = false, string $override_contents = null, bool $is_php_internal_stub = false, ?Request $request = null): Context
            {
                $original_file_path = $file_path;
                $code_base->setCurrentParsedFile($file_path);
                if ($is_php_internal_stub) {
        Severity: Major
        Found in src/Phan/Analysis.php - About 2 hrs to fix

          Function analyzeFunctions has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function analyzeFunctions(CodeBase $code_base, array $file_filter = null): void
              {
                  $plugin_set = ConfigPluginSet::instance();
                  $has_function_or_method_plugins = $plugin_set->hasAnalyzeFunctionPlugins() || $plugin_set->hasAnalyzeMethodPlugins();
                  $show_progress = CLI::shouldShowProgress();
          Severity: Minor
          Found in src/Phan/Analysis.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method analyzeFile has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function analyzeFile(
                  CodeBase $code_base,
                  string $file_path,
                  ?Request $request,
                  string $override_contents = null
          Severity: Minor
          Found in src/Phan/Analysis.php - About 1 hr to fix

            Method parseNodeInContext has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function parseNodeInContext(CodeBase $code_base, Context $context, Node $node)
                {
                    $kind = $node->kind;
                    $context->setLineNumberStart($node->lineno);
            
            
            Severity: Minor
            Found in src/Phan/Analysis.php - About 1 hr to fix

              Function parseFile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function parseFile(CodeBase $code_base, string $file_path, bool $suppress_parse_errors = false, string $override_contents = null, bool $is_php_internal_stub = false, ?Request $request = null): Context
                  {
                      $original_file_path = $file_path;
                      $code_base->setCurrentParsedFile($file_path);
                      if ($is_php_internal_stub) {
              Severity: Minor
              Found in src/Phan/Analysis.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function analyzeClasses has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function analyzeClasses(CodeBase $code_base, array $path_filter = null): void
                  {
                      CLI::progress('classes', 0.0, null);
                      $classes = $code_base->getUserDefinedClassMap();
                      if (\is_array($path_filter)) {
              Severity: Minor
              Found in src/Phan/Analysis.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function parseNodeInContext has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function parseNodeInContext(CodeBase $code_base, Context $context, Node $node)
                  {
                      $kind = $node->kind;
                      $context->setLineNumberStart($node->lineno);
              
              
              Severity: Minor
              Found in src/Phan/Analysis.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method parseFile has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static function parseFile(CodeBase $code_base, string $file_path, bool $suppress_parse_errors = false, string $override_contents = null, bool $is_php_internal_stub = false, ?Request $request = null): Context
              Severity: Minor
              Found in src/Phan/Analysis.php - About 45 mins to fix

                Function analyzeFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function analyzeFile(
                        CodeBase $code_base,
                        string $file_path,
                        ?Request $request,
                        string $override_contents = null
                Severity: Minor
                Found in src/Phan/Analysis.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                                return $inner_context;
                Severity: Major
                Found in src/Phan/Analysis.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $child_context;
                  Severity: Major
                  Found in src/Phan/Analysis.php - About 30 mins to fix

                    The method loadMethodPlugins() has an NPath complexity of 784. The configured NPath complexity threshold is 200.
                    Open

                        public static function loadMethodPlugins(CodeBase $code_base): void
                        {
                            $plugin_set = ConfigPluginSet::instance();
                            $return_type_overrides = $plugin_set->getReturnTypeOverrides($code_base);
                            $return_type_override_fqsen_strings = [];
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    NPathComplexity

                    Since: 0.1

                    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                    Example

                    class Foo {
                        function bar() {
                            // lots of complicated code
                        }
                    }

                    Source https://phpmd.org/rules/codesize.html#npathcomplexity

                    The method analyzeFunctions() has an NPath complexity of 216. The configured NPath complexity threshold is 200.
                    Open

                        public static function analyzeFunctions(CodeBase $code_base, array $file_filter = null): void
                        {
                            $plugin_set = ConfigPluginSet::instance();
                            $has_function_or_method_plugins = $plugin_set->hasAnalyzeFunctionPlugins() || $plugin_set->hasAnalyzeMethodPlugins();
                            $show_progress = CLI::shouldShowProgress();
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    NPathComplexity

                    Since: 0.1

                    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                    Example

                    class Foo {
                        function bar() {
                            // lots of complicated code
                        }
                    }

                    Source https://phpmd.org/rules/codesize.html#npathcomplexity

                    The method loadMethodPlugins() has 110 lines of code. Current threshold is set to 100. Avoid really long methods.
                    Open

                        public static function loadMethodPlugins(CodeBase $code_base): void
                        {
                            $plugin_set = ConfigPluginSet::instance();
                            $return_type_overrides = $plugin_set->getReturnTypeOverrides($code_base);
                            $return_type_override_fqsen_strings = [];
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    The method parseNodeInContext() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                    Open

                        public static function parseNodeInContext(CodeBase $code_base, Context $context, Node $node)
                        {
                            $kind = $node->kind;
                            $context->setLineNumberStart($node->lineno);
                    
                    
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    CyclomaticComplexity

                    Since: 0.1

                    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                    Example

                    // Cyclomatic Complexity = 11
                    class Foo {
                    1   public function example() {
                    2       if ($a == $b) {
                    3           if ($a1 == $b1) {
                                    fiddle();
                    4           } elseif ($a2 == $b2) {
                                    fiddle();
                                } else {
                                    fiddle();
                                }
                    5       } elseif ($c == $d) {
                    6           while ($c == $d) {
                                    fiddle();
                                }
                    7        } elseif ($e == $f) {
                    8           for ($n = 0; $n < $h; $n++) {
                                    fiddle();
                                }
                            } else {
                                switch ($z) {
                    9               case 1:
                                        fiddle();
                                        break;
                    10              case 2:
                                        fiddle();
                                        break;
                    11              case 3:
                                        fiddle();
                                        break;
                                    default:
                                        fiddle();
                                        break;
                                }
                            }
                        }
                    }

                    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                    The method loadMethodPlugins() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
                    Open

                        public static function loadMethodPlugins(CodeBase $code_base): void
                        {
                            $plugin_set = ConfigPluginSet::instance();
                            $return_type_overrides = $plugin_set->getReturnTypeOverrides($code_base);
                            $return_type_override_fqsen_strings = [];
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    CyclomaticComplexity

                    Since: 0.1

                    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                    Example

                    // Cyclomatic Complexity = 11
                    class Foo {
                    1   public function example() {
                    2       if ($a == $b) {
                    3           if ($a1 == $b1) {
                                    fiddle();
                    4           } elseif ($a2 == $b2) {
                                    fiddle();
                                } else {
                                    fiddle();
                                }
                    5       } elseif ($c == $d) {
                    6           while ($c == $d) {
                                    fiddle();
                                }
                    7        } elseif ($e == $f) {
                    8           for ($n = 0; $n < $h; $n++) {
                                    fiddle();
                                }
                            } else {
                                switch ($z) {
                    9               case 1:
                                        fiddle();
                                        break;
                    10              case 2:
                                        fiddle();
                                        break;
                    11              case 3:
                                        fiddle();
                                        break;
                                    default:
                                        fiddle();
                                        break;
                                }
                            }
                        }
                    }

                    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                    The method analyzeFunctions() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                    Open

                        public static function analyzeFunctions(CodeBase $code_base, array $file_filter = null): void
                        {
                            $plugin_set = ConfigPluginSet::instance();
                            $has_function_or_method_plugins = $plugin_set->hasAnalyzeFunctionPlugins() || $plugin_set->hasAnalyzeMethodPlugins();
                            $show_progress = CLI::shouldShowProgress();
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    CyclomaticComplexity

                    Since: 0.1

                    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                    Example

                    // Cyclomatic Complexity = 11
                    class Foo {
                    1   public function example() {
                    2       if ($a == $b) {
                    3           if ($a1 == $b1) {
                                    fiddle();
                    4           } elseif ($a2 == $b2) {
                                    fiddle();
                                } else {
                                    fiddle();
                                }
                    5       } elseif ($c == $d) {
                    6           while ($c == $d) {
                                    fiddle();
                                }
                    7        } elseif ($e == $f) {
                    8           for ($n = 0; $n < $h; $n++) {
                                    fiddle();
                                }
                            } else {
                                switch ($z) {
                    9               case 1:
                                        fiddle();
                                        break;
                    10              case 2:
                                        fiddle();
                                        break;
                    11              case 3:
                                        fiddle();
                                        break;
                                    default:
                                        fiddle();
                                        break;
                                }
                            }
                        }
                    }

                    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                    The class Analysis has a coupling between objects value of 35. Consider to reduce the number of dependencies under 13.
                    Open

                    class Analysis
                    {
                        /**
                         * This first pass parses code and looks for the subset
                         * of issues that can be found without having to have
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    CouplingBetweenObjects

                    Since: 1.1.0

                    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                    Example

                    class Foo {
                        /**
                         * @var \foo\bar\X
                         */
                        private $x = null;
                    
                        /**
                         * @var \foo\bar\Y
                         */
                        private $y = null;
                    
                        /**
                         * @var \foo\bar\Z
                         */
                        private $z = null;
                    
                        public function setFoo(\Foo $foo) {}
                        public function setBar(\Bar $bar) {}
                        public function setBaz(\Baz $baz) {}
                    
                        /**
                         * @return \SplObjectStorage
                         * @throws \OutOfRangeException
                         * @throws \InvalidArgumentException
                         * @throws \ErrorException
                         */
                        public function process(\Iterator $it) {}
                    
                        // ...
                    }

                    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

                    Avoid variables with short names like $i. Configured minimum length is 3.
                    Open

                            $i = 0;
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    ShortVariable

                    Since: 0.2

                    Detects when a field, local, or parameter has a very short name.

                    Example

                    class Something {
                        private $q = 15; // VIOLATION - Field
                        public static function main( array $as ) { // VIOLATION - Formal
                            $r = 20 + $this->q; // VIOLATION - Local
                            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                $r += $this->q;
                            }
                        }
                    }

                    Source https://phpmd.org/rules/naming.html#shortvariable

                    Avoid variables with short names like $i. Configured minimum length is 3.
                    Open

                            $i = 0;
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    ShortVariable

                    Since: 0.2

                    Detects when a field, local, or parameter has a very short name.

                    Example

                    class Something {
                        private $q = 15; // VIOLATION - Field
                        public static function main( array $as ) { // VIOLATION - Formal
                            $r = 20 + $this->q; // VIOLATION - Local
                            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                $r += $this->q;
                            }
                        }
                    }

                    Source https://phpmd.org/rules/naming.html#shortvariable

                    Avoid variables with short names like $e. Configured minimum length is 3.
                    Open

                            Throwable $e
                    Severity: Minor
                    Found in src/Phan/Analysis.php by phpmd

                    ShortVariable

                    Since: 0.2

                    Detects when a field, local, or parameter has a very short name.

                    Example

                    class Something {
                        private $q = 15; // VIOLATION - Field
                        public static function main( array $as ) { // VIOLATION - Formal
                            $r = 20 + $this->q; // VIOLATION - Local
                            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                                $r += $this->q;
                            }
                        }
                    }

                    Source https://phpmd.org/rules/naming.html#shortvariable

                    There are no issues that match your filters.

                    Category
                    Status