Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Analysis/RedundantCondition.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function getLoopNodeTypeFetcher has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getLoopNodeTypeFetcher(CodeBase $code_base, $node): ?Closure
    {
        if (!($node instanceof Node)) {
            // This scalar won't change.
            return null;
Severity: Minor
Found in src/Phan/Analysis/RedundantCondition.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getLoopNodeTypeFetcher has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getLoopNodeTypeFetcher(CodeBase $code_base, $node): ?Closure
    {
        if (!($node instanceof Node)) {
            // This scalar won't change.
            return null;
Severity: Minor
Found in src/Phan/Analysis/RedundantCondition.php - About 1 hr to fix

    Method emitInstance has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function emitInstance(
        $node,
        CodeBase $code_base,
        Context $context,
        string $issue_name,
    Severity: Minor
    Found in src/Phan/Analysis/RedundantCondition.php - About 1 hr to fix

      Method emitInstance has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $node,
        CodeBase $code_base,
        Context $context,
        string $issue_name,
        array $issue_args,
      Severity: Major
      Found in src/Phan/Analysis/RedundantCondition.php - About 50 mins to fix

        Function getVariableSet has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function getVariableSet($node): array
    {
        if (!$node instanceof Node) {
            return [];
        }
        Severity: Minor
        Found in src/Phan/Analysis/RedundantCondition.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function emitInstance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function emitInstance(
        $node,
        CodeBase $code_base,
        Context $context,
        string $issue_name,
        Severity: Minor
        Found in src/Phan/Analysis/RedundantCondition.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status