Sign upLogin

eugene-matvejev/battleship-game-api

View on GitHub
Star

Showing 153 of 153 total issues

Avoid assigning values to variables in if clauses and the like (line '85', column '22').
Open

    public function turnAction(int $cellId) : Response
    {
        if (null === $cell = $this->getDoctrine()->getRepository('GameBundle:Cell')->find($cellId)) {
            throw new CellException(Response::HTTP_NOT_FOUND, "cell: {$cellId} do not exist");
        }
Severity: Minor
Found in src/GameBundle/Controller/GameController.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\EM\GameBundle\Model\CellModel' in method 'turnAction'.
Open

        foreach (CellModel::getChangedCells() as $cell) {
Severity: Minor
Found in src/GameBundle/Controller/GameController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\CellModel' in method 'attackCell'.
Open

        return CellModel::switchPhase($cell);
Severity: Minor
Found in src/GameBundle/Service/AI/AIService.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\CellModel' in method 'processPlayerTurnOnBattlefield'.
Open

        if (CellModel::isShipDead($cell)) {
Severity: Minor
Found in src/GameBundle/Service/GameSystem/GameProcessor.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'prepareResponse'.
Open

            $result = MockFactory::getGameResultMock(2, 0);
Severity: Minor
Found in tests/phpunit/GameBundle/Model/GameResultModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'hasUnfinishedShips'.
Open

        $this->assertTrue(BattlefieldModel::hasUnfinishedShips($battlefield));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\FoundationBundle\Model\PlayerModel' in method 'isAIControlledOnFlagNone'.
Open

        $this->assertFalse(PlayerModel::isAIControlled(MockFactory::getPlayerMock('')));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/PlayerModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'isAIControlledOnFlagAIControlled'.
Open

        $this->assertTrue(PlayerModel::isAIControlled(MockFactory::getAIPlayerMock('')));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/PlayerModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'setCellsProvider'.
Open

            [[MockFactory::getCellMock('A1'), MockFactory::getCellMock('A2')]]
Severity: Minor
Found in tests/phpunit/GameBundle/Response/GameTurnResponseTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'AdjacentCellsProvider'.
Open

        $battlefield = MockFactory::getBattlefieldMock();
Severity: Minor
Found in tests/phpunit/GameBundle/Service/CoordinateSystem/PathProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processPlayerTurnOnBattlefieldToWin'.
Open

        $this->assertTrue($this->processPlayerTurnOnBattlefield($battlefield, MockFactory::getPlayerMock('')));
Severity: Minor
Found in tests/phpunit/GameBundle/Service/GameSystem/GameProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processTurnToNotWin'.
Open

        $aiBattlefield->setPlayer(MockFactory::getAIPlayerMock(''));
Severity: Minor
Found in tests/phpunit/GameBundle/Service/GameSystem/GameProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'hasUnfinishedShips'.
Open

        $this->assertFalse(BattlefieldModel::hasUnfinishedShips($battlefield));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'flagWaterAroundShipOnNonDeadAround'.
Open

        $battlefield = MockFactory::getBattlefieldMock();
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\BattlefieldModel' in method 'flagWaterAroundShipOnA1AlreadyDead'.
Open

        BattlefieldModel::flagWaterAroundShip($cell);
Severity: Minor
Found in tests/phpunit/GameBundle/Model/BattlefieldModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\GameBundle\Model\CellModel' in method 'getChangedCells'.
Open

        $this->assertGreaterThanOrEqual(1, count(CellModel::getChangedCells()));
Severity: Minor
Found in tests/phpunit/GameBundle/Model/CellModelTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\FoundationBundle\Model\PlayerModel' in method 'addBattlefield'.
Open

                if (PlayerModel::isAIControlled($battlefield->getPlayer())) {
Severity: Minor
Found in tests/phpunit/GameBundle/Response/GameInitiationResponseTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'processPathOnValidDeadShipCell'.
Open

        $battlefield = MockFactory::getBattlefieldMock();
Severity: Minor
Found in tests/phpunit/GameBundle/Service/AI/AIStrategyProcessorTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\EM\Tests\Environment\Factory\MockFactory' in method 'chooseCellsOnNoDeadCellsInBattlefield'.
Open

        $this->assertEmpty(static::$aiStrategyService->chooseCells(MockFactory::getBattlefieldMock()));
Severity: Minor
Found in tests/phpunit/GameBundle/Service/AI/AIStrategyServiceTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '67', column '26').
Open

    private function chooseStrategy(Cell $cell) : int
    {
        $processor = new PathProcessor($cell->getCoordinate());

        $battlefield = $cell->getBattlefield();
Severity: Minor
Found in src/GameBundle/Service/AI/AIStrategyService.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Severity
Category
Status
Source
Language